-
Notifications
You must be signed in to change notification settings - Fork 930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Quill to v1.0.3 (stable) #106
Conversation
Upgrade to Quill version 1.0.0-Beta.4
… random whitespace
aaihZ1O0 Prevent extra newlines from being added on creation
- Semver: might be a breaking API change, so call it 2.0 and mark as beta
Do I need special resources of some kind to use this, like fonts or something? I tried using this branch and got some very weird visual effects. Here's a screenshot on Chrome 51 (http://screencast.com/t/tXTJbvdomo) and Firefox 47 (http://screencast.com/t/PlbGkIYFgJpu). I assume it looks and feels good for you, right? |
You need to include the CSS in your app - how that gets pulled in depends on how your project manages assets. See |
Thanks Alex, that was it. I thought I had that under control, but changing repos broke it. |
@alexkrolick I could use this as well; anything I can do to help? |
The fork that this PR is based on is working pretty well for me: https://github.com/alexkrolick/react-quill The original refactoring to work with Quill v1 was done on @clemmy's branch. The main question here is whether to make the react-quill configuration API backwards-compatible with the version using the pre-release Quill. |
Incidentally, this branch is working beautifully for me in dev. |
Quill v1.0.0 is around the corner - would be great to hash out the upgrade path for users still on the pre-release version. Would love any feedback from anyone actively using this fork. |
Quill v1.0.0 is here! Will download and checkout this fork today. I need to access the new header option in our app. |
@igolden v1.0.0 is only at the release candidate stage - there's one more round of testing before it goes out. That said, please check out the fork and report any issues you have upgrading or using the next version of either Quill or this wrapper. EDIT: Also check out the changes in the README about how to work with the new toolbar format. |
Unless anyone needs it I am going to not update the fork for Quill rc.1 because it seems like there may be an issue with the bundling of the packaged min.js: slab/quill#881 |
- bump version to 2.0.0
Quill 1.0.0 has been released, so I've updated the dependency and bumped the major version of the package at my fork. |
Thanks for this incredible contribution! |
Updates
Upgrade Quill dependency to 1.0.0 (#113 )
quill^1.0.0
withreact-quill^2.0.0
added to READMEBreaking changes
getHTML
,addFormat
, and the Toolbar configuration being moved to a module. Please see the official upgrade guide and the new README for more information.Notes
dist/
files for released versions)addFormat
API in favor of passing directly to Quill in config