Skip to content
This repository has been archived by the owner on May 1, 2019. It is now read-only.

Widget Twitter account @zfmodules #465

Merged
merged 3 commits into from
Mar 26, 2015
Merged

Widget Twitter account @zfmodules #465

merged 3 commits into from
Mar 26, 2015

Conversation

gianarb
Copy link
Contributor

@gianarb gianarb commented Mar 5, 2015

Hi!
I opend a new twitter account @zfmodules for this site.
Ifttt tweet every new module updated

@@ -0,0 +1,3 @@
<a class="twitter-timeline" href="https://twitter.com/zfmodules" data-widget-id="573451599546318849">Tweet di @zfmodules</a>
<script>!function(d,s,id){var js,fjs=d.getElementsByTagName(s)[0],p=/^http:/.test(d.location)?'http':'https';if(!d.getElementById(id)){js=d.createElement(s);js.id=id;js.src=p+"://platform.twitter.com/widgets.js";fjs.parentNode.insertBefore(js,fjs);}}(document,"script","twitter-wjs");</script>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you move this to a different file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not in a view helper?
do I move script embedding into layout?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's going to be reloaded every time at every page here. If you move it to $this->headScript() it's much better IMO

@snapshotpl
Copy link
Contributor

Good idea. However we need to focus on tweet using api.

@@ -0,0 +1,2 @@
<a class="twitter-timeline" href="https://twitter.com/zfmodules" data-widget-id="573451599546318849">Tweet di @zfmodules</a>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep account name in config

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And widget id? :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is it? It's user id?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Every twitter's widget has a id :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gianarb

Tweet di @zfmodules

Is this Italian?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I copied code generated by my italian Twitter :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So add it also to config :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my opinion in configuration this params not works.. If I insert this params how arguments of invoke how do you think?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ocramius @ins0 @localheinz opinion about this stuff? :) Thanks

@gianarb
Copy link
Contributor Author

gianarb commented Mar 8, 2015

Rebased.. feedback? In my opinion this repository is for zfmodules site not for an abstract zf modules repository.. :) Move this data into the config is unnecessary

@localheinz
Copy link
Member

@gianarb

I'm not so sure of the actual value of this as I think that you can already see the latest modules when you're on the site. Also, the right column seems a bit crowded with the widget! Since it pushes down the list of newly registered developers, it also decreases the value of that list.

What do you think?

Maybe a simple follow button in the header is sufficient?

@gianarb
Copy link
Contributor Author

gianarb commented Mar 9, 2015

Yes, this is a zfmodules account, in this moment publish only new modules
because is automatic :P But If you would send other tweets is not a
problem..
I have tried to move this widget after contributors box but maybe this
module have a layout's bug :) If the order change is a good proposal can
you try it?

2015-03-09 12:32 GMT+01:00 Andreas Möller [email protected]:

@gianarb https://github.com/gianarb

I'm not so sure of the actual value of this as I think that you can
already see the latest modules when you're on the site. Also, the right
column seems a bit crowded with the widget! Since it pushes down the list
of newly registered developers, it also decreases the value of that list.

What do you think?

Maybe a simple follow button https://dev.twitter.com/web/follow-button
in the header is sufficient?


Reply to this email directly or view it on GitHub
#465 (comment)
.

Gianluca Arbezzano
www.gianarb.it

@gianarb
Copy link
Contributor Author

gianarb commented Mar 21, 2015

screen shot 2015-03-21 at 14 03 38

@gianarb
Copy link
Contributor Author

gianarb commented Mar 23, 2015

Ping @localheinz @Ocramius

:) :)

@gianarb
Copy link
Contributor Author

gianarb commented Mar 26, 2015

ping @localheinz can you push this pr or there are a problems? 😄

@localheinz
Copy link
Member

Thank you, @gianarb!

Only problem here was a lack of time, going to deploy this later tonight when I'll sit together with @ins0, ok?

localheinz added a commit that referenced this pull request Mar 26, 2015
@localheinz localheinz merged commit 5888957 into zendframework:master Mar 26, 2015
@localheinz localheinz self-assigned this Mar 26, 2015
@gianarb
Copy link
Contributor Author

gianarb commented Mar 26, 2015

Np :) thank you!! :)

2015-03-26 14:04 GMT+01:00 Andreas Möller [email protected]:

Merged #465
#465.


Reply to this email directly or view it on GitHub
#465 (comment)
.

Gianluca Arbezzano
www.gianarb.it

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants