This repository has been archived by the owner on May 1, 2019. It is now read-only.
Enhancement: Implement Entity\Repository #455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
localheinz
force-pushed
the
feature/repository-entity
branch
from
418d0da to
b791d90
Compare
localheinz
changed the title
| @@ -99,6 +99,7 @@ | |||
| 'service_manager' => [ | |||
| 'factories' => [ | |||
| \HTMLPurifier::class => Service\HtmlPurifierFactory::class, | |||
| 'github_repository' => Service\GitHubRepositoryFactory::class, | |||
There was a problem hiding this comment.
Naming should probably be project_github_repository or such
There was a problem hiding this comment.
Not sure, I guess because it's mostly used by View\Helper\GitHubRepositoryUrl?
Do you have a suggestion? I'm happy to hear it!
There was a problem hiding this comment.
Hang on a second!
localheinz
force-pushed
the
feature/repository-entity
branch
from
837e841 to
9798664
Compare
localheinz
force-pushed
the
feature/repository-entity
branch
from
9798664 to
3d87297
Compare
localheinz
force-pushed
the
feature/repository-entity
branch
from
3d87297 to
29ac5ed
Compare
localheinz
force-pushed
the
feature/repository-entity
branch
from
36fcbc9 to
b561121
Compare
|
Implemented the changes as suggested! |
Ocramius
added a commit
that referenced
this pull request
Mar 4, 2015
Enhancement: Implement Entity\Repository
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Application\Entity\RepositoryService\GitHubRepositoryFactoryreturning anEntity\Repositorywith values retrieved from configurationController\ContributorsControllerandView\Helper\GitHubRepositoryto rely on that entity, rather than a configuration arrayFollows #447 (comment).