Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aspect rules js update #3146

Merged
merged 2 commits into from
May 28, 2023
Merged

aspect rules js update #3146

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
38bce95
Update dependency aspect_rules_js to v1.27.0
zemnmez-renovate-bot May 27, 2023
5b1febf
remove old publication code (which is replaced by aspect_rules_js
Zemnmez May 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions bzl/deps.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,9 +220,9 @@ exports_files(glob(["**/*"], exclude_directories=0))

http_archive(
name = "aspect_rules_js",
sha256 = "08061ba5e5e7f4b1074538323576dac819f9337a0c7d75aee43afc8ae7cb6e18",
strip_prefix = "rules_js-1.26.1",
url = "https://github.com/aspect-build/rules_js/releases/download/v1.26.1/rules_js-v1.26.1.tar.gz",
sha256 = "d8827db3c34fe47607a0668e86524fd85d5bd74f2bfca93046d07f890b5ad4df",
strip_prefix = "rules_js-1.27.0",
url = "https://github.com/aspect-build/rules_js/releases/download/v1.27.0/rules_js-v1.27.0.tar.gz",
)

http_archive(
Expand Down
19 changes: 8 additions & 11 deletions js/npm/rules.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,17 +103,14 @@ def npm_pkg(
out = name + ".tgz",
)

npm.npm_binary(
name = name + ".publish",
data = [name + "_dir"],
args = ["publish", "$(location " + name + "_dir)", "--cache", "$$TMPDIR"],
)

npm.npm_test(
name = name + ".publish_test",
data = [name + "_dir"],
args = ["publish", "$(location " + name + "_dir)", "--dry-run", "--cache", "$$TMPDIR"],
)
####
# TODO: probably re-do this test.
####
# npm.npm_test(
# name = name + ".publish_test",
# data = [name + "_dir"],
# args = ["publish", "$(location " + name + "_dir)", "--dry-run", "--cache", "$$TMPDIR"],
#)

pkg_srcs = srcs
pkg_deps = deps + [pkg_json_name]
Expand Down