Improve TypeScript highlights #18525
Merged
+84
−63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
cla-signed
Huliiiiii
commented
Sep 30, 2024
Comment on lines
7
to
11
| ((identifier) @constructor | ||
| (#match? @constructor "^[A-Z]")) | ||
|
|
||
| ((identifier) @type | ||
| (#match? @type "^[A-Z]")) |
There was a problem hiding this comment.
The second query always overwrites the first, can anyone explain why it's written in this way?
There was a problem hiding this comment.
This also causes CamelCase variables to be highlighted as types.
There was a problem hiding this comment.
I think we can remove the constructor one. Thanks for catching that.
maxdeviant
changed the title
maxbrunsfeld
approved these changes
Jan 7, 2025
Comment on lines
7
to
11
| ((identifier) @constructor | ||
| (#match? @constructor "^[A-Z]")) | ||
|
|
||
| ((identifier) @type | ||
| (#match? @type "^[A-Z]")) |
There was a problem hiding this comment.
I think we can remove the constructor one. Thanks for catching that.
|
@Huliiiiii It looks like there are some merge conflicts that need to be resolved. Once those are resolved I think this will be in a state that we can merge. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@type.builtinConfused about case-based queries, should they be rewritten?
Release Notes: