Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix response time improperly configured for micro-seconds. #1265

Merged
merged 5 commits into from
Sep 7, 2023

Conversation

monkut
Copy link
Collaborator

@monkut monkut commented Aug 16, 2023

Description

Microseconds were not properly being output into the log via the common_log() function.
This PR corrects the coversion of seconds to microseconds and clarifies the units used.

GitHub Issues

#1229

@coveralls
Copy link

coveralls commented Aug 16, 2023

Coverage Status

coverage: 74.695% (+0.007%) from 74.688% when pulling 44175b2 on fix/wrong-microseconds-log-display into f2f03ba on master.

Copy link
Collaborator

@souravjamwal77 souravjamwal77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A screenshot with the results was sent to @monkut. Approved

@monkut monkut requested review from hellno and goya813 August 18, 2023 01:17
@monkut monkut merged commit 7fba630 into master Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants