Remove obsolete check for Django version < 1.7 #1158
Assignees
Labels
Comments
|
Yes, considering Django 1.7 is no longer supported by django I think it's fair to remove this unnecessary code. |
|
released in 0.56.0, closing. |
Ian288
pushed a commit
to tackle-io/Zappa
that referenced
this issue
Jul 11, 2023
Remove special check for Django<1.7
BarNehemia
added a commit
to Lightricks/Zappa
that referenced
this issue
Aug 10, 2023
…zappa-0.57.0 * commit '0b1eab14ca39c3a3bfb4e915347e07495171dcba': (27 commits) updating workflow actions to remove deprecation warnings (zappa#1243) 📝 CHANGELOG.md update for 0.57.0 (zappa#1246) fixing compatibility with Django 4.2 (zappa#1237) Update Readme with patreon and donors (zappa#1234) adding support for Python 3.10 (zappa#1231) Nose to pytest (zappa#1239) lint: updating code style with `make black` (zappa#1238) Alternative way to check if running in Docker (zappa#1204) 📝 CHANGELOG.md update for 0.56.0 release (zappa#1187) Improve `get_best_match_zone()` to match by most matched components instead of by length of domain (zappa#1193) Bypass python version runtime check when code run in docker (zappa#1180) Be able to pass in a batch window when using batch size (zappa#1118) Correction to README. (zappa#1177) (zappa#908) Update BINARY_SUPPORT to use Content-Encoding to identify if data is binary (zappa#1155) Remove special check for Django<1.7, fix for zappa#1158 (zappa#1159) Resolve (zappa#410) Logs are missing query strings (zappa#1165) Handle spaces in x-forwared-for/remove six (zappa#1127) (zappa#1163) add feature (zappa#704) Check if args/kwargs are JSON Serializable while running locally (zappa#1154) docs: Add documentation for s3 event object key_filters (zappa#1169) Add feature pyenv virtualenv detecting .python-version file (zappa#1153) ... # Conflicts: # zappa/cli.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There is a check for Django version being < 1.7, which triggers a now-unnecessary call to
django.setup()Context
Zappa supports Python 3.7-3.9 and Django only supports Python of 3.5 or greater since version 2.2. So anyway, can remove this check.
Expected Behavior
No behavior changes, though Django<1.7 will no longer work, if it did in any case.
Actual Behavior
No change
Possible Fix
Remove code
The text was updated successfully, but these errors were encountered: