Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add slug suffix for uid dashboards #222

Merged
merged 1 commit into from
Jul 19, 2023

Conversation

vindex10
Copy link
Contributor

Hi! I suggest a flag to enable additional suffix for UID dashboards.

If the flag is disabled, like this UID_DASHBOARD_SLUG_SUFFIX=false (which is default and backwards compatible),
the dashboard name is smth like aiofo1324hou2hr.dashboard.

when the flag is enabled UID_DASHBOARD_SLUG_SUFFIX=true, then the name also includes the slug:
aiofo1324hou2hr-some-nice-name.dashboard

@acjohnson
Copy link
Collaborator

I'm not sure I understand the purpose of this change. What benefit is there in adding a custom suffix to the dashboard filenames?

@vindex10
Copy link
Contributor Author

vindex10 commented Jul 19, 2023

Hi @acjohnson , thank you for attention!

Suffixes simplify the process of restoring one dashboard manually. Just makes it easier to navigate through the back up files.

Of course you pay with consistency after renaming, but then it is up to the user.

We would sacrifice consistency for easier navigation, for example.

@acjohnson
Copy link
Collaborator

Ah okay it actually gets the slug from the dashboard metadata. I tested it and since it defaults to off I think this is fine.

@acjohnson acjohnson merged commit cd7a5ea into ysde:master Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants