Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace patterns within files of a particular type #18

Closed
Dowwie opened this issue Oct 24, 2018 · 7 comments
Closed

replace patterns within files of a particular type #18

Dowwie opened this issue Oct 24, 2018 · 7 comments

Comments

@Dowwie
Copy link

Dowwie commented Oct 24, 2018

I'd like to replace patterns within files of a particular type, such as "--type rust". This feature is demonstrated within ripgrep.

@dmerejkowsky
Copy link
Collaborator

dmerejkowsky commented Oct 24, 2018

Seems like the feature is implemented in ignore, a crate we already depend on.

So should be easy to implement :)

@dmerejkowsky dmerejkowsky reopened this Oct 24, 2018
dmerejkowsky added a commit that referenced this issue Dec 4, 2018
This works fine, but needs refactoring and tests

Start working on #18
@dmerejkowsky
Copy link
Collaborator

@Dowwie PR is here :)

Please tell me if you need things like --type-add or --type-clear. They exist in rg, but I'm not sure we need them in ruplacer too.

@Dowwie
Copy link
Author

Dowwie commented Dec 5, 2018

@dmerejkowsky exciting! will let you know. thank you for implementing this!

when do you plan to release to crate?

@dmerejkowsky
Copy link
Collaborator

As soon as #23 is accepted :)

@dmerejkowsky
Copy link
Collaborator

0.3.0 is out. Enjoy :)

@Dowwie
Copy link
Author

Dowwie commented Dec 5, 2018

@dmerejkowsky works! :) this is a great enhancement. did you also modify highlighting?

@dmerejkowsky
Copy link
Collaborator

If you're talking about #15 we may have a solution but it needs more work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants