Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update modified timestamps on save (closes #1191) #1211

Merged
merged 8 commits into from
Dec 27, 2024
Merged

Update modified timestamps on save (closes #1191) #1211

merged 8 commits into from
Dec 27, 2024

Conversation

tomchop
Copy link
Collaborator

@tomchop tomchop commented Dec 21, 2024

No description provided.

@tomchop tomchop added this to the 2.3 milestone Dec 21, 2024
@tomchop tomchop requested a review from udgover December 21, 2024 12:44
@tomchop tomchop requested a review from sebdraven December 21, 2024 13:03
udgover
udgover reviewed Dec 23, 2024
View reviewed changes
Copy link
Collaborator

@udgover udgover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't you think it would be better to override save() method to set modified timestamp and then call super().save() ? The advantage being it will be handled at one place.

@tomchop tomchop requested a review from udgover December 27, 2024 13:53
udgover
udgover approved these changes Dec 27, 2024
View reviewed changes
Copy link
Collaborator

@udgover udgover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tomchop tomchop merged commit 6e8035f into main Dec 27, 2024
2 checks passed
@tomchop tomchop deleted the updated branch December 27, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@udgover udgover udgover approved these changes

@sebdraven sebdraven Awaiting requested review from sebdraven

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
2.3
Development

Successfully merging this pull request may close these issues.
2 participants
@tomchop @udgover