Migrations #1181
Merged
Migrations #1181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
udgover
approved these changes
Nov 28, 2024
There was a problem hiding this comment.
Really cool and needed PR! I'm approving it even if I have a question regarding migration number handling.
Should we also include a command in yetictl rather than running poetry run python core/migrations/arangodb.py?
This will also be useful to handle stop_at argument.
core/migrations/migration.py
Outdated
| def update_db_version(self, version: int): | ||
| raise NotImplementedError | ||
|
|
||
| def migrate_to_latest(self, stop_at: int = None): |
There was a problem hiding this comment.
Why don't rely on migration name which already includes a number?
There was a problem hiding this comment.
The functions are arbitrarily named, so we wanna calculate them from the order they've been pushed in
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a migration framework for ArangoDB and includes an initial migration to update the database to version 2.
The migration framework allows for incremental updates to the database schema and data, ensuring that the database remains consistent across different versions of the application.
This initial migration ensures that a new field introduced in #1175,
is_valid, is populated on all database Obseravbles.