Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests for GDAL 3.9. #447

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Fix tests for GDAL 3.9. #447

merged 1 commit into from
Nov 14, 2024

Conversation

evetion
Copy link
Collaborator

@evetion evetion commented Nov 13, 2024 •
edited
Loading

Fixes #444

Changes

  • FastGetExtent is now supported
  • GDAL now seals layer definitions, which we cannot undo via C, making this test mostly moot.
  • unsafe_gdaldem crashes the Julia process because of invalid arguments

The latter two require further changes, but it would be good to have the CI green for other PRs first.

@asinghvi17 asinghvi17 mentioned this pull request Nov 13, 2024
Merged
yeesian
yeesian approved these changes Nov 14, 2024
View reviewed changes
Copy link
Owner

@yeesian yeesian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this!

@yeesian yeesian merged commit b6c95c1 into master Nov 14, 2024
11 of 12 checks passed
@yeesian yeesian deleted the fix/tests branch November 14, 2024 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yeesian yeesian yeesian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Broken tests on recent GDAL
2 participants
@evetion @yeesian