Correct paths and imports for step 4 #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slothkong
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was first pointed out in issue #53. I read the complete normalization.py script and seems like is not a code braking issue to have equal paths for target and source:
https://github.com/CUHKSZ-TQL/EverybodyDanceNow_reproduce_pytorch/blob/0080a4debceabfcccd777d13da9c083621c809c4/normalization.py#L14-L17
In any case source and target images/labels are all 512x512 and
get_scale()does not require poses data to estimate the scale of the image and the head. However, for the sake of clarity and debugging I amended the paths.There was also a typo in the README, about the output directory of transfer.py.
In addition I fixed the imports (no module named src) and paths problem in (preapare.py)[https://github.com/CUHKSZ-TQL/EverybodyDanceNow_reproduce_pytorch/blob/master/face_enhancer/prepare.py] that were reported in #29, #14, #37 and #28. I made small corrections in the README to make it more clear how to execute the face enhancement step.
Finally, I add a fix for the dataset loading error reported in #43.
Hope this helps.