This repository has been archived by the owner on Dec 10, 2024. It is now read-only.
feat: implement 'allowed_email_domains_list' group attribute #2059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timofurrer
suggested changes
Nov 14, 2024
There was a problem hiding this comment.
@jeremad I did a first round of review and left some comments. Back to you 🏓
jeremad
force-pushed
the
jrm/email_domains
branch
from
7d576d6 to
fd1c548
Compare
|
@timofurrer all fixed |
timofurrer
suggested changes
Nov 15, 2024
There was a problem hiding this comment.
@jeremad looks good, thanks! I've left a suggestion to fix another copy&paste mistake.
jeremad
force-pushed
the
jrm/email_domains
branch
from
fd1c548 to
4f7ea73
Compare
|
@timofurrer fixed! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.