-
Notifications
You must be signed in to change notification settings - Fork 516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/7.0.2xx-xcode14.3] [dotnet] Add a property to opt-out of the _CopyLocalBindingResources logic easily. #18450
Conversation
…logic easily. It seems this target has more problems than at first I thought, so make it easier to opt-out of it by just setting a property in the csproj. More investigation is needed, but I'm keeping the target on by default for now, since it solves a real-world problem as well.
✅ API diff for current PR / commitNET (empty diffs)
✅ API diff vs stable.NET (No breaking changes)✅ Generator diffGenerator diff is empty Pipeline on Agent |
💻 [CI Build] Windows Integration Tests passed 💻✅ All Windows Integration Tests passed. Pipeline on Agent |
💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻✅ All tests on macOS M1 - Mac Big Sur (11.5) passed. Pipeline on Agent |
💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻✅ All tests on macOS M1 - Mac Ventura (13.0) passed. Pipeline on Agent |
🚀 [CI Build] Test results 🚀Test results✅ All tests passed on VSTS: simulator tests. 🎉 All 79 tests passed 🎉 Tests counts
Pipeline on Agent |
It seems this target has more problems than at first I thought, so make it
easier to opt-out of it by just setting a property in the csproj.
More investigation is needed, but I'm keeping the target on by default for
now, since it solves a real-world problem as well.
Ref: #18445
Backport of #18443