Add code review comments on tests not corrected as they are disabled

xamarin · Jul 27, 2022 · e970880 · e970880
1 parent 02f4555
commit e970880
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 0 deletions.
diff --git a/tests/monotouch-test/Foundation/NSArray1Test.cs b/tests/monotouch-test/Foundation/NSArray1Test.cs
@@ -117,6 +117,8 @@ public void GetDifferenceFromArrayTest ()
 						return first.ToString ().Equals (second.ToString ());
 					});
 			}, "Not throws");
+			// https://github.com/xamarin/xamarin-macios/issues/15577 - Did not rewrite tests that were disabled
+			// Maybe assert that we get a specific diff result as well?
 			Assert.NotNull (diff, "Not null");
 		}
 #endif

diff --git a/tests/monotouch-test/Foundation/NSOrderedCollectionDifference1Test.cs b/tests/monotouch-test/Foundation/NSOrderedCollectionDifference1Test.cs
@@ -25,6 +25,10 @@ public void InsertionsAndRemovalsTest ()
 			Assert.DoesNotThrow (() => {
 				var r = diff.Removals;
 			});
+			// https://github.com/xamarin/xamarin-macios/issues/15577 - Did not rewrite tests that were disabled
+			// Any reason for not asserting on the returned value?
+			// Assert.AreEqual (1, diff.Insertions.Length, "insertions");
+			// (or whatever it's supposed to return)
 		}
 	}
 #endif

diff --git a/tests/monotouch-test/Foundation/NSOrderedCollectionDifferenceTest.cs b/tests/monotouch-test/Foundation/NSOrderedCollectionDifferenceTest.cs
@@ -25,6 +25,10 @@ public void InsertionsAndRemovalsTest ()
 			Assert.DoesNotThrow (() => {
 				var r = diff.Removals;
 			});
+			// https://github.com/xamarin/xamarin-macios/issues/15577 - Did not rewrite tests that were disabled
+			// Any reason for not asserting on the returned value?
+			// Assert.AreEqual (1, diff.Insertions.Length, "insertions");
+			// (or whatever it's supposed to return)
 		}
 	}
 #endif