Skip to content

Commit

Permalink
[dotnet] Add a property to opt-out of the _CopyLocalBindingResources …
Browse files Browse the repository at this point in the history
…logic easily. (#18443)

It seems this target has more problems than at first I thought, so make
it easier to opt-out of it by just setting a property in the csproj.

More investigation is needed, but I'm keeping the target on by default
for now, since it solves a real-world problem as well.

Ref: #18445
  • Loading branch information
rolfbjarne authored Jun 15, 2023
1 parent 7df3eb1 commit 2761123
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion dotnet/targets/Xamarin.Shared.Sdk.targets
Original file line number Diff line number Diff line change
Expand Up @@ -1898,7 +1898,11 @@ global using nfloat = global::System.Runtime.InteropServices.NFloat%3B
</ItemGroup>
</Target>

<Target Name="_CopyLocalBindingResources" AfterTargets="ResolveAssemblyReferences" BeforeTargets="CopyFilesToOutputDirectory">
<Target Name="_CopyLocalBindingResources"
AfterTargets="ResolveAssemblyReferences"
BeforeTargets="CopyFilesToOutputDirectory"
Condition="'$(_DisableCopyLocalBindingResources)' != 'true'"
>
<!--
We need to copy binding resource packages (either zipped or as a
Expand Down

6 comments on commit 2761123

@vs-mobiletools-engineering-service2

This comment was marked as outdated.

@vs-mobiletools-engineering-service2

This comment was marked as outdated.

@vs-mobiletools-engineering-service2

This comment was marked as outdated.

@vs-mobiletools-engineering-service2

This comment was marked as outdated.

@vs-mobiletools-engineering-service2

This comment was marked as outdated.

@vs-mobiletools-engineering-service2

This comment was marked as outdated.

Please sign in to comment.