Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests and deprecations with Sidekiq 5 #130

Merged
merged 3 commits into from
Jun 21, 2017
Merged

Fix tests and deprecations with Sidekiq 5 #130

merged 3 commits into from
Jun 21, 2017

Conversation

packrat386
Copy link
Collaborator

@packrat386 packrat386 commented Jun 7, 2017 •
edited
Loading

  • Turn on BeDelayed with Sidekiq versions >= 5
  • Test against old versions of Sidekiq
  • Fix deprecation warning to only show on calling deprecated method(s)

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.4%) to 89.722% when pulling d2bb446 on packrat386:fix_sidekiq_5 into ac4528e on philostler:develop.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage decreased (-1.4%) to 89.722% when pulling d2bb446 on packrat386:fix_sidekiq_5 into ac4528e on philostler:develop.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.4%) to 89.722% when pulling d2bb446 on packrat386:fix_sidekiq_5 into ac4528e on philostler:develop.

@coveralls
Copy link

Coverage Status

Coverage increased (+6.1%) to 97.222% when pulling 5d47461 on packrat386:fix_sidekiq_5 into ac4528e on philostler:develop.

4 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+6.1%) to 97.222% when pulling 5d47461 on packrat386:fix_sidekiq_5 into ac4528e on philostler:develop.

@coveralls
Copy link

Coverage Status

Coverage increased (+6.1%) to 97.222% when pulling 5d47461 on packrat386:fix_sidekiq_5 into ac4528e on philostler:develop.

@coveralls
Copy link

Coverage Status

Coverage increased (+6.1%) to 97.222% when pulling 5d47461 on packrat386:fix_sidekiq_5 into ac4528e on philostler:develop.

@coveralls
Copy link

Coverage Status

Coverage increased (+6.1%) to 97.222% when pulling 5d47461 on packrat386:fix_sidekiq_5 into ac4528e on philostler:develop.

@mlarraz
Copy link

mlarraz commented Jun 7, 2017

This is not actually removed in Sidekiq 5, just disabled by default. See: https://github.com/mperham/sidekiq/blob/master/5.0-Upgrade.md

You just need to put something like

Sidekiq::Extensions.enable_delay! if Sidekiq::VERSION > 4

in your test setup.

@trev
Copy link
Contributor

trev commented Jun 7, 2017 •
edited
Loading

@packrat386

The BeDelayed matcher can still work in Sidekiq 5+ if enabled: https://github.com/mperham/sidekiq/blob/master/5.0-Upgrade.md#whats-new

I enable in order to test here: https://github.com/philostler/rspec-sidekiq/pull/126/files#diff-93830fa29d616f7c87903d08b5b1b29aR25

@trev
Copy link
Contributor

trev commented Jun 7, 2017

Beat me to the punch @mlarraz!

This was referenced Jun 7, 2017
Closed
Closed
Closed
trev and others added 2 commits June 21, 2017 14:49
@trev @packrat386
Enable Sidekiq delay extension for >5.0.0
f5e1721
@packrat386
Ensure tests run for Sidekiq 4
ec20e85 
We want to make sure we still support the old version while adding
support for the new one.
@coveralls
Copy link

Coverage Status

Coverage increased (+6.1%) to 97.222% when pulling ec20e85 on packrat386:fix_sidekiq_5 into ac4528e on philostler:develop.

4 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+6.1%) to 97.222% when pulling ec20e85 on packrat386:fix_sidekiq_5 into ac4528e on philostler:develop.

@coveralls
Copy link

Coverage Status

Coverage increased (+6.1%) to 97.222% when pulling ec20e85 on packrat386:fix_sidekiq_5 into ac4528e on philostler:develop.

@coveralls
Copy link

Coverage Status

Coverage increased (+6.1%) to 97.222% when pulling ec20e85 on packrat386:fix_sidekiq_5 into ac4528e on philostler:develop.

@coveralls
Copy link

Coverage Status

Coverage increased (+6.1%) to 97.222% when pulling ec20e85 on packrat386:fix_sidekiq_5 into ac4528e on philostler:develop.

@packrat386 packrat386 changed the title Fix tests for Sidekiq 5 Fix tests and deprecations with Sidekiq 5 Jun 21, 2017
@coveralls
Copy link

Coverage Status

Coverage increased (+6.7%) to 97.778% when pulling 32d2f99 on packrat386:fix_sidekiq_5 into ac4528e on philostler:develop.

1 similar comment
@coveralls
Copy link

coveralls commented Jun 21, 2017 •
edited
Loading

Coverage Status

Coverage increased (+6.7%) to 97.778% when pulling 32d2f99 on packrat386:fix_sidekiq_5 into ac4528e on philostler:develop.

@packrat386
Copy link
Collaborator Author

@trev cherry-picked your commits in here so I can make one green PR.

@packrat386 packrat386 merged commit be6f635 into wspurgin:develop Jun 21, 2017
@packrat386 packrat386 deleted the fix_sidekiq_5 branch June 21, 2017 20:42
sshao
sshao reviewed Jun 21, 2017
View reviewed changes
.travis.yml
@@ -18,3 +18,5 @@ matrix:
include:
- rvm: 2.0
gemfile: gemfiles/ruby20.gemfile
- rmv: 2.4
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be rvm, i'm guessing

This was referenced Jun 23, 2017
Closed
Closed
@foobear foobear mentioned this pull request Jun 23, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sshao sshao sshao left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@packrat386 @coveralls @mlarraz @trev @sshao