build: Upgrade to React Native 0.73 (iOS) #6612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcalhoun
commented
Feb 6, 2024
| @@ -20,7 +20,7 @@ def setup_rnreanimated_pod_from_fork | |||
| puts "[Gutenberg] Set REACT_NATIVE_NODE_MODULES_DIR env var for RNReanimated to #{rn_node_modules}" | |||
|
|
|||
| # Use a custom RNReanimated version while we coordinate a fix upstream | |||
| pod 'RNReanimated', git: 'https://github.com/wordpress-mobile/react-native-reanimated', branch: 'wp-fork-2.17.0' | |||
| pod 'RNReanimated', git: 'https://github.com/wordpress-mobile/react-native-reanimated', branch: 'wp-fork-3.6.2' | |||
There was a problem hiding this comment.
react-native-reanimated 3.x is required for React Native 0.73 compatibility.
Comment on lines
-81
to
-85
| # The following workaround is needed to avoid the error `typedef redefinition with different types ('uint8_t' (aka 'unsigned char') vs 'enum clockid_t')`. | ||
| # This solution is referenced in https://github.com/facebook/react-native/issues/39568#issuecomment-1762890606. | ||
| # It will be needed until RCT-Folly version is bumped in React Native to version v2022.08.29.00 or above. | ||
| # Referece: https://github.com/facebook/folly/commit/4a2410fae65afb85e1fec6d922005054b05de59f | ||
| __apply_Xcode_12_5_M1_post_install_workaround(installer) |
There was a problem hiding this comment.
The __apply_Xcode_12_5_M1_post_install_workaround method was removed from React Native core as it is no longer necessary.
ios-xcframework/Podfile.lock
Outdated
There was a problem hiding this comment.
I was required to delete the Podfile.lock file entirely to get pod install to succeed. Otherwise, I encountered an infinite loop of incompatible Pod versions.
There was a problem hiding this comment.
These changes were a result of running npm run xcframework:build.
There was a problem hiding this comment.
These changes and the others to sibling podspec files were the result of running the ./bin/generate-podspecs.sh script.
Required for compatibility with React Native 0.73.
This method no longer exists after the React Native 0.73 upgrade. It is also no longer necessary.
This is the result of running the following command. ``` npm run xcframework:build ``` It also required deleting the `Podfile.lock` entirely, as installing pods failed due a loop of errors and requests to update individual pods in search of compatible versions between pods.
Without wrapping this in `act` an error is thrown in the test.
Some CLI commands were hoisted from the dedicated CLI package into React Native core. Without React Native installed in the top level of this project, scripts will fail due to missing commands. This is considered a workaround currently. It would be ideal to avoid the need to duplicate this dependency that is already within the Gutenberg core project, but it may be unavoidable due to the CLI changes in core.
This reverts commit e09ff7f.
dcalhoun
force-pushed
the
build/upgrade-to-react-native-0.73-iOS
branch
from
e09ff7f to
a6597d2
Compare
dcalhoun
merged commit 98acc57
into
version-toolkit/gutenberg/build/upgrade-to-react-native-0.73
0 of 2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade the iOS code for React Native 0.73.
To test: Will be tested later as a part of WordPress/gutenberg#58475.
PR submission checklist: