Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass the Gallery v2 Flag over from the editor #3713

Conversation

chipsnyder
Copy link
Contributor

@chipsnyder chipsnyder commented Jul 8, 2021

Related PRs
gutenberg: WordPress/gutenberg#33314
WordPress-iOS: wordpress-mobile/WordPress-iOS#16832
WordPressKit-iOS: wordpress-mobile/WordPressKit-iOS#417

To test:

This can be tested with the instructions contained here: WordPress/gutenberg#33314

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@chipsnyder chipsnyder changed the title Update Gutenberg version Pass the Gallery v2 Flag over from the editor Jul 8, 2021
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jul 9, 2021

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

Copy link

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@antonis antonis force-pushed the rnmobile/refactor/gallery-as-nested-image-blocks-editor-settings_v2 branch from fc43069 to bab8f5c Compare September 1, 2021 07:39
@antonis antonis self-assigned this Sep 1, 2021
@antonis antonis requested a review from mkevins September 1, 2021 08:49
@antonis antonis marked this pull request as ready for review September 1, 2021 08:49
@antonis antonis force-pushed the rnmobile/refactor/gallery-as-nested-image-blocks-editor-settings_v2 branch from bab8f5c to f05560d Compare September 1, 2021 14:57
Copy link
Contributor

@mkevins mkevins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested via: wordpress-mobile/WordPress-iOS#16832 (review) and everything is working as expected. Thanks! 👍

@antonis antonis force-pushed the rnmobile/refactor/gallery-as-nested-image-blocks-editor-settings_v2 branch from 5a3af03 to edc7a75 Compare September 2, 2021 09:47
@antonis antonis merged commit 4cf60fd into develop Sep 2, 2021
@antonis antonis deleted the rnmobile/refactor/gallery-as-nested-image-blocks-editor-settings_v2 branch September 2, 2021 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[OS] iOS [Type] Enhancement Improves a current area of the editor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants