Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: When using enablePaging={true} and horizontal={true}, showsHorizontalScrollIndicator={false} does not work. #904

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fjlyx97
Copy link

@fjlyx97 fjlyx97 commented Jan 11, 2025

When using enablePaging={true}, horizontal={true}, and showsHorizontalScrollIndicator={false}.
The scroll indicator is still showing. I attempted to fix this issue.

…nent

- Added `showsHorizontalScrollIndicator` and `showsVerticalScrollIndicator` props to PdfView.js for better user control over scroll indicators.
- Refactored RNPDFPdfView.mm to streamline the handling of scroll indicator visibility using a new `setScrollIndicators` method, improving code maintainability.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants