Add VS2022 support and misc #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
namrog84
commented
May 4, 2022
| @@ -155,11 +156,6 @@ | |||
| <ItemGroup> | |||
| <Midl Include="ReactPackageProvider.idl" /> | |||
| </ItemGroup> | |||
| <ItemGroup> | |||
| <ProjectReference Include="$(ReactNativeWindowsDir)\Microsoft.ReactNative\Microsoft.ReactNative.vcxproj"> | |||
There was a problem hiding this comment.
This was only originally needed before Microsoft.ReactNative.Uwp.CppLib.props and Microsoft.ReactNative.Uwp.CppLib.targets was added and imported. And those were added long ago.
|
Hi @wonday, is there anything I can do or change that would help get this in? 👍 |
Nesh108
approved these changes
Jul 19, 2022
|
@wonday we definitely need this PR otherwise this package won't work with newer versions of React-Native. |
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
new NativeEventEmitter()was called with a non-null argument without the requiredaddListenermethod.