Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix addOrientationListener for Android and add example project #140

Merged
merged 4 commits into from
Sep 14, 2020
Merged

Fix addOrientationListener for Android and add example project #140

merged 4 commits into from
Sep 14, 2020

Conversation

r0b0t3d
Copy link
Contributor

@r0b0t3d r0b0t3d commented Sep 12, 2020

@wonday Please help review this PR.

What is included

  1. Add example project
  2. Fix version 1.2.0 addOrientationListener not working on android #139
  3. Add hooks useOrientationChange, useDeviceOrientationChange
  4. Add note BREAKING CHANGES to v1.2.0

image
image

@r0b0t3d r0b0t3d mentioned this pull request Sep 12, 2020
Closed
@r0b0t3d r0b0t3d changed the title Add example project Fix addOrientationListener for Android and add example project Sep 12, 2020
@wonday wonday merged commit 2f04965 into wonday:master Sep 14, 2020
@wonday
Copy link
Owner

wonday commented Sep 14, 2020

It's cool. Thank you.

@r0b0t3d r0b0t3d mentioned this pull request Oct 2, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

version 1.2.0 addOrientationListener not working on android
2 participants
@r0b0t3d @wonday