Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for not finding @ReactModule #125

Merged
merged 2 commits into from
Apr 20, 2020
Merged

Fix for not finding @ReactModule #125

merged 2 commits into from
Apr 20, 2020

Conversation

dpnolte
Copy link
Contributor

@dpnolte dpnolte commented Apr 17, 2020

Since RN 0.58 we need to add @ReactModule annotation for accessing the module natively:

Native Modules in Android now require @ReactModule annotations to access .getNativeModule method on the ReactContext

https://github.com/react-native-community/releases/blob/master/CHANGELOG.md#breaking-changes-

This PR adds the annotation. I've also removed some unused imports and added some gitignore rules for Android. Thanks for the awesome library

@wonday wonday merged commit 1685701 into wonday:master Apr 20, 2020
@wonday
Copy link
Owner

wonday commented Apr 20, 2020

Thank you.

@r0b0t3d r0b0t3d mentioned this pull request Sep 12, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dpnolte @wonday