Fix for issue #2056

[BBE78]

Added .editorconfig file to customize environment
Updated .eslintrc config file to match rules

[wbt]

Thanks! This looks fine to me; I'll give it some time to see if any other maintainers might have an opinion on this.

[DABH]

Did adding these editor settings not change any files? Was the intent to add editor settings that matched what was already in the repo? If so, this is fine with me, no strong feelings either way.

[BBE78]

Did adding these editor settings not change any files? Was the intent to add editor settings that matched what was already in the repo? If so, this is fine with me, no strong feelings either way.

Yes, I adapt the config according to existing files (Windows EOL, 2 spaces indent, etc.)

[maverick1872]

No strong feelings here so long as we're consistent.

[BBE78]

No strong feelings here so long as we're consistent.

Great!

[maverick1872]

Fixes #2056

I'll merge this in a couple days if no one else chimes in on this.

[DABH]

It seems like we didn't merge master into this or something before merging this PR. Master is failing all CI checks due to weird line endings which are coming from the updated settings here. npm run lint should pass. @BBE78 Can you please investigate this and perhaps revert and parts of your PR (e.g. related to line endings) that are causing all the CI failures? Thanks!

[BBE78]

@DABH I will have a look, seems to be bad EOL in my modified files... 🤔

[BBE78]

If you're talking about this job, it looks strange.
When I run the npm run lint script, it says:

> [email protected] lint
> populist lib/*.js lib/winston/*.js lib/winston/**/*.js


C:\Users\Benoît\Documents\GitHub\winston\lib\winston\logger.js
   81:12  warning  Method 'configure' has a complexity of 17                               complexity
   81:12  warning  Method 'configure' has too many statements (20). Maximum allowed is 15  max-statements
  201:6   warning  Method 'log' has a complexity of 12                                     complexity
  201:6   warning  Method 'log' has too many statements (26). Maximum allowed is 15        max-statements

C:\Users\Benoît\Documents\GitHub\winston\lib\winston\tail-file.js
  63:57  warning  Arrow function has a complexity of 13                               complexity
  63:57  warning  Arrow function has too many statements (30). Maximum allowed is 15  max-statements

C:\Users\Benoît\Documents\GitHub\winston\lib\winston\transports\console.js
  44:6  warning  Method 'log' has too many statements (19). Maximum allowed is 15  max-statements

C:\Users\Benoît\Documents\GitHub\winston\lib\winston\transports\file.js
  263:18  warning  'buff' is already declared in the upper scope     no-shadow
  324:29  warning  'options' is already declared in the upper scope  no-shadow

✖ 9 problems (0 errors, 9 warnings)

But the job has been executed on an Ubuntu OS, and if I remember every *nix OS doesn't like CRLF ending lines...
So, to fix this issue, I'will downgrade the CRLF ending lines to a warn (instead of error) in the ESLint config.

[BBE78]

Fix proposed in Pull Request #2070

[maverick1872]

Hmm this is interesting as all the checks on the branch passed without issue. Since I merged this I'll also do some investigation.