Skip to content

Commit

Permalink
[#1813] Use fork of diagnostics, avoiding indirect storage-engine dep…
Browse files Browse the repository at this point in the history 
…endency
  • Loading branch information
@DABH
DABH committed Jun 22, 2020
1 parent b47d5d5 commit 67cd9b5
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 20 deletions.
22 changes: 3 additions & 19 deletions package-lock.json
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
],
"dependencies": {
"async": "^3.1.0",
"diagnostics": "^2.0.2",
"diagnostics": "DABH/diagnostics#master",
"is-stream": "^2.0.0",
"logform": "^2.2.0",
"one-time": "^1.0.0",
Expand Down

7 comments on commit 67cd9b5

@playka
Copy link

@playka playka commented on 67cd9b5 Jun 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bad idea

@vim-daniel
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pretty much killed my ci...

@hyoussef
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here that broke our ci ...

@surya-purohit
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's really bad, it breaks ci

@bhagirathgudi
Copy link

@bhagirathgudi bhagirathgudi commented on 67cd9b5 Jun 22, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really bad, I was scratching my head, whats happening. But then I found this.

@fertavora
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Filed an issue to fix this: #1818

@DABH
Copy link
Contributor Author

@DABH DABH commented on 67cd9b5 Jun 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see #1814 , thanks.

Please sign in to comment.