Skip to content

Commit

Permalink
Add Jest to MW Core for testing Vue components
Browse files Browse the repository at this point in the history
This brings Jest to MW Core so that Vue components can more easily be
tested. Packages ending with 'icons.json' are auto-mapped to the
@wikimedia/codex-icons package, establishing a new convention.
Jest is needed for testing Vue, but can be used for general JS testing
as well. Documentation to come at https://www.mediawiki.org/wiki/Jest

Usage: to run the tests, run "npx jest" or "npm run jest" in the root
folder. This could be aliased to a "test:unit" script in package.json
if desired.

In order to make a Vue component testable, it is required to follow the
`module.exports = exports` pattern. See:
https://nodejs.org/api/modules.html#exports-shortcut

A default jest.setup.js is added that mocks Core's mw global object, as
well as providing the $i18n Vue plugin. This is based on
Extension:GrowthExperiments (GPL-3.0-or-later). See https://w.wiki/B9vM

An initial test for mediawiki.special.block is added, exemplifying how
to mock calls to mw.config.get().

NOTE: The "overrides" added to package.json is a temporary measure to
get around a current issue with caniuse-lite and the stylelint plugin
that relies on it. See:
RJWadley/stylelint-no-unsupported-browser-features#299

Bug: T251790
Change-Id: I1af15e038d17b0f1c645fc5debf9db5846f6215c
  • Loading branch information
egardner authored and MusikAnimal committed Sep 11, 2024
1 parent 5319d0b commit 48798f1
Show file tree
Hide file tree
Showing 14 changed files with 22,427 additions and 10,748 deletions.
32,813 changes: 22,074 additions & 10,739 deletions package-lock.json

Large diffs are not rendered by default.

14 changes: 13 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,15 +10,21 @@
"qunit": "grunt qunit",
"selenium-daily": "npm run selenium-test -- --mochaOpts.grep @daily",
"selenium-test": "wdio ./tests/selenium/wdio.conf.js",
"test": "grunt lint && npm run doc"
"test": "grunt lint && npm run doc && npm run jest",
"jest": "jest --config tests/jest/jest.config.js"
},
"devDependencies": {
"@apidevtools/swagger-parser": "^10.1.0",
"@babel/preset-env": "7.25.4",
"@vue/test-utils": "2.4.6",
"@vue/vue3-jest": "29.2.6",
"@wdio/cli": "7.33.0",
"@wdio/junit-reporter": "7.33.0",
"@wdio/local-runner": "7.33.0",
"@wdio/mocha-framework": "7.33.0",
"@wdio/spec-reporter": "7.33.0",
"@wikimedia/codex": "1.12.0",
"@wikimedia/codex-icons": "1.12.0",
"@wikimedia/karma-firefox-launcher": "2.1.3",
"api-testing": "1.6.0",
"domino": "2.1.0",
Expand All @@ -30,6 +36,8 @@
"grunt-eslint": "24.3.0",
"grunt-karma": "4.0.2",
"grunt-stylelint": "0.20.0",
"jest": "29.7.0",
"jest-environment-jsdom": "29.7.0",
"jsdoc": "4.0.2",
"jsdoc-wmf-theme": "1.1.0",
"karma": "6.4.1",
Expand All @@ -39,7 +47,11 @@
"qunit": "2.20.0",
"stylelint-config-wikimedia": "0.17.2",
"svgo": "3.2.0",
"vue": "3.4.27",
"wdio-mediawiki": "file:tests/selenium/wdio-mediawiki",
"xml2js": "^0.6.2"
},
"overrides": {
"caniuse-lite": "1.0.30001653"
}
}
2 changes: 1 addition & 1 deletion resources/src/mediawiki.special.block/SpecialBlock.vue
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ const ReasonField = require( './components/ReasonField.vue' );
const BlockDetailsField = require( './components/BlockDetailsOptions.vue' );
// @vue/component
module.exports = defineComponent( {
module.exports = exports = defineComponent( {
name: 'SpecialBlock',
components: {
UserLookup,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ const { defineComponent, toRef } = require( 'vue' );
const { CdxCheckbox, CdxField, useModelWrapper } = require( '@wikimedia/codex' );
// @vue/component
module.exports = defineComponent( {
module.exports = exports = defineComponent( {
name: 'BlockDetailsField',
components: { CdxCheckbox, CdxField },
props: {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ const { defineComponent, ref, toRef } = require( 'vue' );
const { CdxCheckbox, CdxRadio, CdxField, useModelWrapper } = require( '@wikimedia/codex' );
// @vue/component
module.exports = defineComponent( {
module.exports = exports = defineComponent( {
name: 'BlockTypeField',
components: { CdxCheckbox, CdxRadio, CdxField },
props: {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@
const { defineComponent, ref, computed, watch } = require( 'vue' );
const { CdxField, CdxRadio, CdxSelect, CdxTextInput } = require( '@wikimedia/codex' );
module.exports = defineComponent( {
module.exports = exports = defineComponent( {
name: 'ExpiryField',
components: {
CdxField,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
const { defineComponent } = require( 'vue' );
// @vue/component
module.exports = defineComponent( {
module.exports = exports = defineComponent( {
name: 'ReasonField'
} );
</script>
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
const { defineComponent } = require( 'vue' );
// @vue/component
module.exports = defineComponent( {
module.exports = exports = defineComponent( {
name: 'TargetActiveBlocks'
} );
</script>
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
const { defineComponent } = require( 'vue' );
// @vue/component
module.exports = defineComponent( {
module.exports = exports = defineComponent( {
name: 'TargetBlockLog'
} );
</script>
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ const { CdxLookup, CdxField, useModelWrapper } = require( '@wikimedia/codex' );
const { cdxIconSearch } = require( '../icons.json' );
// @vue/component
module.exports = defineComponent( {
module.exports = exports = defineComponent( {
name: 'UserLookup',
components: { CdxLookup, CdxField },
props: {
Expand Down
23 changes: 23 additions & 0 deletions tests/jest/.eslintrc.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
{
"root": true,
"extends": [
"wikimedia/client-common",
"wikimedia/language/es2020",
"wikimedia/jquery",
"wikimedia/mediawiki"
],
"parserOptions": {
"sourceType": "module"
},
"env": {
"browser": true,
"jest": true
},
"globals": {
"global": "writable"
},
"rules": {
"compat/compat": [ "error", "last 2 chrome versions, last 2 firefox versions" ],
"max-len": "off"
}
}
204 changes: 204 additions & 0 deletions tests/jest/jest.config.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,204 @@
'use strict';

/*
* For a detailed explanation regarding each configuration property, visit:
* https://jestjs.io/docs/configuration
*/
module.exports = {
// All imported modules in your tests should be mocked automatically
// automock: false,

// Stop running tests after `n` failures
// bail: 0,

// The directory where Jest should store its cached dependency information
// cacheDirectory: '/private/var/folders/4c/2pxczd5n1c7_7z_s5djxfx5w0000gn/T/jest_dx',

// Automatically clear mock calls, instances and results before every test
clearMocks: true,

// Indicates whether the coverage information should be collected while executing the test
collectCoverage: false,

// An array of glob patterns indicating a set of files for which coverage information should be
// collected
// collectCoverageFrom: undefined,

// The directory where Jest should output its coverage files
coverageDirectory: 'coverage',

// An array of regexp pattern strings used to skip coverage collection
// coveragePathIgnorePatterns: [
// '/node_modules/'
// ],

// Indicates which provider should be used to instrument code for coverage
// coverageProvider: "babel",

// A list of reporter names that Jest uses when writing coverage reports
// coverageReporters: [
// 'json',
// 'text',
// 'lcov',
// 'clover'
// ],

// An object that configures minimum threshold enforcement for coverage results
// coverageThreshold: undefined,

// A path to a custom dependency extractor
// dependencyExtractor: undefined,

// Make calling deprecated APIs throw helpful error messages
// errorOnDeprecated: false,

// Force coverage collection from ignored files using an array of glob patterns
// forceCoverageMatch: [],

// A path to a module which exports an async function that is triggered once before all test suites
// globalSetup: undefined,

// A path to a module which exports an async function that is triggered once after all test suites
// globalTeardown: undefined,

// A set of global variables that need to be available in all test environments
// globals: {},

// The maximum amount of workers used to run your tests. Can be specified as % or a number. E.g. maxWorkers: 10% will use 10% of your CPU amount + 1 as the maximum worker number. maxWorkers: 2 will use a maximum of 2 workers.
// maxWorkers: '50%',

// An array of directory names to be searched recursively up from the requiring module's location
// moduleDirectories: [
// 'node_modules'
// ],

// An array of file extensions your modules use
moduleFileExtensions: [
'js',
'json',
'vue'
],

// A map from regular expressions to module names or to arrays of module names that allow to stub out resources with a single module
moduleNameMapper: {
'icons.json$': '@wikimedia/codex-icons'
},

// An array of regexp pattern strings, matched against all module paths before considered 'visible' to the module loader
// modulePathIgnorePatterns: [],

// Activates notifications for test results
// notify: false,

// An enum that specifies notification mode. Requires { notify: true }
// notifyMode: 'failure-change',

// A preset that is used as a base for Jest's configuration
// preset: undefined,

// Run tests from one or more projects
// projects: undefined,

// Use this configuration option to add custom reporters to Jest
// reporters: undefined,

// Automatically reset mock state before every test
// resetMocks: false,

// Reset the module registry before running each individual test
// resetModules: false,

// A path to a custom resolver
// resolver: undefined,

// Automatically restore mock state and implementation before every test
// restoreMocks: false,

// The root directory that Jest should scan for tests and modules within
rootDir: '../../',

// A list of paths to directories that Jest should use to search for files in
// roots: [
// '<rootDir>'
// ],

// Allows you to use a custom runner instead of Jest's default test runner
// runner: 'jest-runner',

// The paths to modules that run some code to configure or set up the testing environment before each test
setupFiles: [
'<rootDir>/tests/jest/jest.setup.js'
],

// A list of paths to modules that run some code to configure or set up the testing framework before each test
// setupFilesAfterEnv: [],

// The number of seconds after which a test is considered as slow and reported as such in the results.
// slowTestThreshold: 5,

// A list of paths to snapshot serializer modules Jest should use for snapshot testing
// snapshotSerializers: [],

// The test environment that will be used for testing
testEnvironment: 'jsdom',

// Options that will be passed to the testEnvironment
testEnvironmentOptions: {
customExportConditions: [ 'node', 'node-addons' ]
},

// Adds a location field to test results
// testLocationInResults: false,

// The glob patterns Jest uses to detect test files
testMatch: [
'<rootDir>/tests/jest/**/*.test.js'
],

// An array of regexp pattern strings that are matched against all test paths, matched tests are skipped
testPathIgnorePatterns: [
'/node_modules/',
'/vendor/',
'/skins/',
'/extensions/',
'/tests/qunit/'
],

// The regexp pattern or array of patterns that Jest uses to detect test files
// testRegex: [],

// This option allows the use of a custom results processor
// testResultsProcessor: undefined,

// This option allows use of a custom test runner
// testRunner: 'jest-circus/runner',

// This option sets the URL for the jsdom environment. It is reflected in properties such as location.href
// testURL: 'http://localhost',

// Setting this value to "fake" allows the use of fake timers for functions such as "setTimeout"
// timers: 'real',

// A map from regular expressions to paths to transformers
transform: {
'^.+\\.vue$': '<rootDir>/node_modules/@vue/vue3-jest'
}

// An array of regexp pattern strings that are matched against all source file paths, matched files will skip transformation
// transformIgnorePatterns: [
// '/node_modules/',
// '\\.pnp\\.[^\\/]+$'
// ],

// An array of regexp pattern strings that are matched against all modules before the module loader will automatically return a mock for them
// unmockedModulePathPatterns: undefined,

// Indicates whether each individual test should be reported during the run
// verbose: undefined,

// An array of regexp patterns that are matched against all source file paths before re-running tests in watch mode
// watchPathIgnorePatterns: [],

// Whether to use watchman for file crawling
// watchman: true,
};
Loading

0 comments on commit 48798f1

Please sign in to comment.