Return failure in state override scheme parsing #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is necessary to define the behavior of the Location object’s protocol attribute, which throws on syntax errors rather than silently ignoring them as other protocol setters do. Tests: web-platform-tests/wpt#4412. This is the cleanup work mentioned in whatwg/html@f0a7365 that is happening way late.
|
When committing this, mention #61. Closing that properly warrants a couple more tests I think for non-broken schemes. |
domenic
added a commit
to jsdom/whatwg-url
that referenced
this pull request
Jan 12, 2017
This matches whatwg/url#194. It has no observable consequences for mainstream uses of this library, but instead impacts consumers which parse using state overrides (like jsdom).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary to define the behavior of the Location object’s
protocol attribute, which throws on syntax errors rather than silently
ignoring them as other protocol setters do.
Tests: web-platform-tests/wpt#4412.
This is the cleanup work mentioned in
whatwg/html@f0a7365
that is happening way late.