Editorial: improve fragment parsing #10874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the argument order consistent and corrects a false statement about what the XML fragment parser returns. It also generally improves alignment with Infra and other best practices, though it does not improve the actual integration with the parsers.
sideshowbarker
approved these changes
Dec 31, 2024
AtkinsSJ
added a commit
to AtkinsSJ/ladybird
that referenced
this pull request
Jan 7, 2025
Corresponds to whatwg/html#10874 Also, parse_fragment() returns ExceptionOr, so stop voiding the error from append_child().
gmta
pushed a commit
to LadybirdBrowser/ladybird
that referenced
this pull request
Jan 7, 2025
Corresponds to whatwg/html#10874 Also, parse_fragment() returns ExceptionOr, so stop voiding the error from append_child().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the argument order consistent and corrects a false statement about what the XML fragment parser returns. It also generally improves alignment with Infra and other best practices, though it does not improve the actual integration with the parsers.
Noticed this while working on scoped custom element registries.
/dynamic-markup-insertion.html ( diff )
/parsing.html ( diff )
/xhtml.html ( diff )