Fix writing a loder instructions #3723
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/webpack-docs/webpack-js-org/h7v6nlfp0 |
| } | ||
| }] | ||
| } | ||
| }); | ||
|
|
||
| compiler.outputFileSystem = createFsFromVolume(new Volume()); | ||
| const volume = createFsFromVolume(new Volume()); | ||
| volume.join = path.join; |
There was a problem hiding this comment.
There was a problem hiding this comment.
Without this, it throws error: TypeError: this.outputFileSystem.join is not a function
| @@ -377,6 +377,9 @@ __package.json__ | |||
| { | |||
| "scripts": { | |||
| "test": "jest" | |||
| }, | |||
| "jest": { | |||
| "testEnvironment": "node" | |||
There was a problem hiding this comment.
| options: { | ||
| name: 'Alice' | ||
| } | ||
| options, |
There was a problem hiding this comment.
I think it's bit nicer to pass options from your tests so this is more reusable.
|
Oh, I didn't notice there's already a similar pull request here before I submit #3739. I should search the pull request first next time. |
|
Thanks! |
When I followed the tutorial for writing loader, I have noticed couple of issues, see the inline comments.