custom-elements: Add a test for customized built-in elements coverage.

[tkent-google]

No description provided.

[ghost]

Build PASSED

Started: 2018-01-24 07:12:16
Finished: 2018-01-24 07:20:46

This report has been truncated because the number of unstable tests exceeds GitHub.com's character limit for comments (65536 characters).

Failing Jobs

• safari:11.0

Unstable Browsers

Browser: "Safari 11.0" (failures allowed)

View in: WPT PR Status | TravisCI

[TakayoshiKochi]

LGTM

[snuggs]

@tkent-google @TakayoshiKochi first would like to say AMAZING work on this. Been a long time coming. 🎉

Looking at ways can contribute more here. Am good at refactoring. Was wondering could we foreach the elements instead of explicitly defining each one? Also did notice a few edge cases towards the end of the setup.

At minimum I believe constructor () { super () } is supperfluous and can just use class extends HTML...Element {}.

At least for HTMLElement Which theoretically should mean the rest. I don't see why native elements would require a constructor. Would at least save 3 * number_of_common_elements lines of code.

Just a thought FWIW.

Great work nonetheless. And FAST too!

[tkent-google]

Yeah, the test has a lot of rooms for improvement. Feel free to change it!

[snuggs]

Yeah, the test has a lot of rooms for improvement

Indeed. However reminds me of one of my favorite quotes. "Better to have a finished stick figure than an unfinished Picasso". Favorite YES. Practicing in my coding NO :-( . I need to print that by my IDE lolz.

Feel free to change it!

You don't have to ask me twice!

Happy Friday @tkent-google !