Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T6817 & T6825 updates - fw_rules override and replaced fixes #368

Open
wants to merge 21 commits into
base: main
Choose a base branch
from

Conversation

omnom62
Copy link
Contributor

@omnom62 omnom62 commented Dec 18, 2024

Change Summary

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

Component(s) name

Proposed changes

How to test

Test results

  • Sanity tests passed
  • Unit tests passed

Tested against VyOS versions:

  • 1.3.8
  • 1.4-rolling-202201010100

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the ansible sanity and unit tests
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added unit tests to cover my changes
  • I have added a file to changelogs/fragments to describe the changes

@omnom62 omnom62 changed the title T6817 updates - fw_rules override fixes T6817 & T6825 updates - fw_rules override and replaced fixes Dec 26, 2024
@gaige
Copy link
Contributor

gaige commented Dec 27, 2024

You'll need to add the changelog file (note: you can't just amend another file, it needs a new file to pass the tests).

@omnom62 omnom62 marked this pull request as ready for review January 8, 2025 04:56
@omnom62 omnom62 requested review from gaige and a team January 8, 2025 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants