Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to ruby 2.7 #247

Merged
merged 4 commits into from
May 31, 2024
Merged

update to ruby 2.7 #247

merged 4 commits into from
May 31, 2024

Conversation

nevinsm
Copy link
Contributor

@nevinsm nevinsm commented May 31, 2024

change node install to workaround legacy OS issues
remove chromedriver due to legacy os issues
update postgres version

…s, remove chromedriver due to legacy os issues, update postgres version
@nevinsm nevinsm requested a review from noahko96 May 31, 2024 21:27
Copy link
Contributor

@noahko96 noahko96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look fine to me but it seems like something broke in the CI.

Copy link
Contributor

@noahko96 noahko96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining errors in spec are fine, looks good.

@nevinsm nevinsm merged commit ec4ce28 into main May 31, 2024
1 check failed
@nevinsm nevinsm deleted the nsm/ruby-upgrade branch May 31, 2024 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants