-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new sample viewer #29
Conversation
✅ Deploy Preview for vertigis-web-incubator ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
The issues with the cypress environment have been addressed. Apparently the Currently blocked because the deployment directory of the sample viewer build has changed to |
Do we know what is causing the double load? |
Yes, it loads the first time as an empty shell before it figures out what library should be active, adjusts the configuration and reloads. Maybe it would be possible to make this seem less glitchy by suppressing the visibility of everything until it's actually ready... |
Added a loading spinner to make the initial load seem snappier and less glitchy. It only shows up on netlify or if you run |
@vertigis/web-sdk
to build and run as the samples themselvesThere's an issue still present with
cypress
that needs to be addressed. It can kind of be worked around here but right now it prevents loading samples other than the default, and interacting directly with the 'map' object.Both of these require access to the parent window of the iframe, and this isn't resolving correctly within the cypress environment. This will be a much bigger problem in the
vertigis-web-samples
repo than here.