-
Notifications
You must be signed in to change notification settings - Fork 27.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use ErrorOverlayLayout in Errors component #74107
Use ErrorOverlayLayout in Errors component #74107
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The UI for pagination and tool buttons group will look different as this is temporarily relocating the components, and it is understandable as those are the ones that need to be placed outside of the overlay.
this feels not like the right direction we should go, it shouldn't effect the UI layout or styling while refactoring
Tests Passed |
Stats from current PRDefault BuildGeneral
Client Bundles (main, webpack)
Legacy Client Bundles (polyfills)
Client Pages
Client Build Manifests
Rendered Page Sizes
Edge SSR bundle Size
Middleware size
Next Runtimes
build cache
Diff detailsDiff for main-HASH.jsDiff too large to display Diff for app-page-exp..ntime.dev.jsfailed to diff Diff for app-page.runtime.dev.jsfailed to diff |
eaec8d8
to
4fc13a5
Compare
5742ae1
to
dd4ad2d
Compare
4fc13a5
to
56f46f2
Compare
dd4ad2d
to
c7316f7
Compare
Merge activity
|
56f46f2
to
db85ee2
Compare
c7316f7
to
6a949b7
Compare
db85ee2
to
25f1b9d
Compare
6a949b7
to
ea9a71b
Compare
ea9a71b
to
b4419bb
Compare
This PR modified the
Errors
(Runtime Error component) to use the sharedErrorOverlayLayout
.