-
Notifications
You must be signed in to change notification settings - Fork 27.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor simplifications to renderToWebStream
#31553
Minor simplifications to renderToWebStream
#31553
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Failing test suitesCommit: 35817ed test/integration/react-18/test/index.test.js
Expand output● Concurrent mode › concurrentFeatures is enabled (dev) › should resolve suspense modules on server side if suspense
● Concurrent mode › concurrentFeatures is enabled (dev) › should resolve suspense on server side if not suspended on server
● Concurrent mode › concurrentFeatures is enabled (dev) › should resolve suspense on server side if suspended on server
● Concurrent mode › concurrentFeatures is enabled (dev) › should hydrate suspenses on client side if suspended on server
● Concurrent mode › concurrentFeatures is enabled (dev) › should drain the entire response
● Concurrent mode › concurrentFeatures is enabled (prod) › should resolve suspense modules on server side if suspense
● Concurrent mode › concurrentFeatures is enabled (prod) › should resolve suspense on server side if not suspended on server
● Concurrent mode › concurrentFeatures is enabled (prod) › should resolve suspense on server side if suspended on server
● Concurrent mode › concurrentFeatures is enabled (prod) › should hydrate suspenses on client side if suspended on server
● Concurrent mode › concurrentFeatures is enabled (prod) › should drain the entire response
test/integration/react-streaming-and-server-components/test/index.test.js
Expand output● concurrentFeatures - prod › should support React.lazy and dynamic imports
● concurrentFeatures - prod › should render the correct html
● concurrentFeatures - prod › should suspense next/link on server side
● concurrentFeatures - prod › should suspense next/image on server side
● concurrentFeatures - prod › should support multi-level server component imports
● concurrentFeatures - prod › should support streaming
● concurrentFeatures - dev › should support React.lazy and dynamic imports
● concurrentFeatures - dev › should render the correct html
● concurrentFeatures - dev › should suspense next/link on server side
● concurrentFeatures - dev › should suspense next/image on server side
● concurrentFeatures - dev › should support multi-level server component imports
● concurrentFeatures - dev › should support streaming
● CSS dev › should include global styles under
● CSS dev › should include global styles with
● CSS prod › should include global styles under
● CSS prod › should include global styles with
|
Stats from current PRDefault Build (Increase detected
|
vercel/next.js canary | azukaru/next.js x-clean-up-render-to-web-stream | Change | |
---|---|---|---|
buildDuration | 22.1s | 22.1s | |
buildDurationCached | 4.3s | 4.4s | |
nodeModulesSize | 338 MB | 338 MB | -1.56 kB |
Page Load Tests Overall increase ✓
vercel/next.js canary | azukaru/next.js x-clean-up-render-to-web-stream | Change | |
---|---|---|---|
/ failed reqs | 0 | 0 | ✓ |
/ total time (seconds) | 3.561 | 3.491 | -0.07 |
/ avg req/sec | 701.99 | 716.16 | +14.17 |
/error-in-render failed reqs | 0 | 0 | ✓ |
/error-in-render total time (seconds) | 1.775 | 1.629 | -0.15 |
/error-in-render avg req/sec | 1408.36 | 1534.62 | +126.26 |
Client Bundles (main, webpack, commons)
vercel/next.js canary | azukaru/next.js x-clean-up-render-to-web-stream | Change | |
---|---|---|---|
450.HASH.js gzip | 179 B | 179 B | ✓ |
framework-HASH.js gzip | 42.2 kB | 42.2 kB | ✓ |
main-HASH.js gzip | 28.3 kB | 28.3 kB | ✓ |
webpack-HASH.js gzip | 1.45 kB | 1.45 kB | ✓ |
Overall change | 72.2 kB | 72.2 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | azukaru/next.js x-clean-up-render-to-web-stream | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 31 kB | 31 kB | ✓ |
Overall change | 31 kB | 31 kB | ✓ |
Client Pages
vercel/next.js canary | azukaru/next.js x-clean-up-render-to-web-stream | Change | |
---|---|---|---|
_app-HASH.js gzip | 1.37 kB | 1.37 kB | ✓ |
_error-HASH.js gzip | 194 B | 194 B | ✓ |
amp-HASH.js gzip | 312 B | 312 B | ✓ |
css-HASH.js gzip | 327 B | 327 B | ✓ |
dynamic-HASH.js gzip | 2.38 kB | 2.38 kB | ✓ |
head-HASH.js gzip | 350 B | 350 B | ✓ |
hooks-HASH.js gzip | 635 B | 635 B | ✓ |
image-HASH.js gzip | 4.45 kB | 4.45 kB | ✓ |
index-HASH.js gzip | 263 B | 263 B | ✓ |
link-HASH.js gzip | 1.87 kB | 1.87 kB | ✓ |
routerDirect..HASH.js gzip | 321 B | 321 B | ✓ |
script-HASH.js gzip | 383 B | 383 B | ✓ |
withRouter-HASH.js gzip | 318 B | 318 B | ✓ |
85e02e95b279..7e3.css gzip | 107 B | 107 B | ✓ |
Overall change | 13.3 kB | 13.3 kB | ✓ |
Client Build Manifests
vercel/next.js canary | azukaru/next.js x-clean-up-render-to-web-stream | Change | |
---|---|---|---|
_buildManifest.js gzip | 460 B | 460 B | ✓ |
Overall change | 460 B | 460 B | ✓ |
Rendered Page Sizes
vercel/next.js canary | azukaru/next.js x-clean-up-render-to-web-stream | Change | |
---|---|---|---|
index.html gzip | 522 B | 522 B | ✓ |
link.html gzip | 535 B | 535 B | ✓ |
withRouter.html gzip | 517 B | 517 B | ✓ |
Overall change | 1.57 kB | 1.57 kB | ✓ |
Default Build with SWC (Increase detected ⚠️ )
General Overall decrease ✓
vercel/next.js canary | azukaru/next.js x-clean-up-render-to-web-stream | Change | |
---|---|---|---|
buildDuration | 23.6s | 23.8s | |
buildDurationCached | 4.3s | 4.4s | |
nodeModulesSize | 338 MB | 338 MB | -1.56 kB |
Page Load Tests Overall increase ✓
vercel/next.js canary | azukaru/next.js x-clean-up-render-to-web-stream | Change | |
---|---|---|---|
/ failed reqs | 0 | 0 | ✓ |
/ total time (seconds) | 3.814 | 3.667 | -0.15 |
/ avg req/sec | 655.41 | 681.78 | +26.37 |
/error-in-render failed reqs | 0 | 0 | ✓ |
/error-in-render total time (seconds) | 1.808 | 1.691 | -0.12 |
/error-in-render avg req/sec | 1382.57 | 1478.74 | +96.17 |
Client Bundles (main, webpack, commons)
vercel/next.js canary | azukaru/next.js x-clean-up-render-to-web-stream | Change | |
---|---|---|---|
450.HASH.js gzip | 179 B | 179 B | ✓ |
framework-HASH.js gzip | 42.3 kB | 42.3 kB | ✓ |
main-HASH.js gzip | 28.6 kB | 28.6 kB | ✓ |
webpack-HASH.js gzip | 1.44 kB | 1.44 kB | ✓ |
Overall change | 72.5 kB | 72.5 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | azukaru/next.js x-clean-up-render-to-web-stream | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 31 kB | 31 kB | ✓ |
Overall change | 31 kB | 31 kB | ✓ |
Client Pages
vercel/next.js canary | azukaru/next.js x-clean-up-render-to-web-stream | Change | |
---|---|---|---|
_app-HASH.js gzip | 1.35 kB | 1.35 kB | ✓ |
_error-HASH.js gzip | 180 B | 180 B | ✓ |
amp-HASH.js gzip | 305 B | 305 B | ✓ |
css-HASH.js gzip | 321 B | 321 B | ✓ |
dynamic-HASH.js gzip | 2.38 kB | 2.38 kB | ✓ |
head-HASH.js gzip | 342 B | 342 B | ✓ |
hooks-HASH.js gzip | 622 B | 622 B | ✓ |
image-HASH.js gzip | 4.47 kB | 4.47 kB | ✓ |
index-HASH.js gzip | 256 B | 256 B | ✓ |
link-HASH.js gzip | 1.91 kB | 1.91 kB | ✓ |
routerDirect..HASH.js gzip | 314 B | 314 B | ✓ |
script-HASH.js gzip | 375 B | 375 B | ✓ |
withRouter-HASH.js gzip | 309 B | 309 B | ✓ |
85e02e95b279..7e3.css gzip | 107 B | 107 B | ✓ |
Overall change | 13.2 kB | 13.2 kB | ✓ |
Client Build Manifests
vercel/next.js canary | azukaru/next.js x-clean-up-render-to-web-stream | Change | |
---|---|---|---|
_buildManifest.js gzip | 459 B | 459 B | ✓ |
Overall change | 459 B | 459 B | ✓ |
Rendered Page Sizes
vercel/next.js canary | azukaru/next.js x-clean-up-render-to-web-stream | Change | |
---|---|---|---|
index.html gzip | 523 B | 523 B | ✓ |
link.html gzip | 536 B | 536 B | ✓ |
withRouter.html gzip | 517 B | 517 B | ✓ |
Overall change | 1.58 kB | 1.58 kB | ✓ |
Simplifies
renderToWebStream
a little bit for #31223