Add initial support for multiple profiles #7301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| let argPath = process.argv[1]; | ||
| if (argPath && process.platform === 'win32') { | ||
| if (/[a-zA-Z]:"/.test(argPath)) { | ||
| argPath = argPath.replace('"', sep); |
Check failure
Code scanning / CodeQL
Incomplete string escaping or encoding
LabhanshAgrawal
force-pushed
the
profiles
branch
from
ba6157c to
951e4de
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
LabhanshAgrawal
force-pushed
the
profiles
branch
from
951e4de to
1c97667
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
LabhanshAgrawal
force-pushed
the
profiles
branch
from
df2eb2b to
277b8cc
Compare
|
Hi there, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for defining multiple profiles and a new tab dropdown
Right now, it supports defining different
shell,shellArgs,envandworkingDirectoryacross profiles.E.g.
Fun fact - you can use
/usr/bin/sshas shell too.I have not added keyboard shortcuts yet, will have to think more about that. Right now the only way to open a different profile is to go through the new tab dropdown, once opened splits and new tabs should follow current focused pane's profile.
UI config options for profiles to come later.
Fixes #1147
Fixes #3436
Fixes #6448