Normalize shell name before selecting URL-matching regex #2070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
ppot
approved these changes
Aug 10, 2017
|
I will integrate it. However we plan on moving webviews to a specific component later on ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ready for merge - no work left. One potential snag is the additional
'path'import; implementing the logic directly without relying on the import wouldn't be a problem, though.This fix improves URL/webview support by normalizing shell identifiers prior to attempting to select a respective URL-matching pattern from
lib/utils/url-regex.js's (shell-identifier-keyed) exports. This mitigates an issue where settingconfig.shellto an absolute path, and/or a binary name including the file extension would disable the URL/filepath-triggered webview behavior.