Refactor SVN Value Conversion Logic into a Separate Function #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
January 6, 2025 19:37
Signed-off-by: Akhilesh Kr. Yadav <[email protected]>
Signed-off-by: Akhilesh Kr. Yadav <[email protected]>
Signed-off-by: Akhilesh Kr. Yadav <[email protected]>
|
PTAL @thomas-fossati . Thanks! |
added 2 commits
January 8, 2025 18:18
Signed-off-by: Akhilesh Kr. Yadav <[email protected]>
Signed-off-by: Akhilesh Kr. Yadav <[email protected]>
There was a problem hiding this comment.
Thanks for your contribution @Akhilesh-max !
I've left a small suggestion inline.
Signed-off-by: Akhilesh Kr. Yadav <[email protected]>
|
Thanks for the review, @thomas-fossati! Updated as per the suggestions. |
thomas-fossati
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors the SVN value conversion logic into a separate function to improve readability and maintainability. The newly created function handles the conversion of various types to for SVN.
Changes made :-
A new function convertToSVNUint64() is created to handle the conversion of various types to uint64 for SVN. Existing functions in svn.go NewTaggedSVN() and NewTaggedMinSVN() have been refactored to use this newly created function convertToSVNUint64().