feat: support method signatures in objects #1511
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While there is no built-in formatter for functions, it's still nice to be able to parse method signatures in objects. Among other, having no parser for this means types referencing types with bivariance-hacks, which is used in a lot of TS libraries, among other React - wont be able to be parsed at all. For instance:
This PR solves this by adding support for method signatures.
I had to be a bit creative in the tests, as there's no formatter so the
assertValidSchema
utility wont work. Therefore, I added a newassertMissingFormatterFor
utility that implicilty tests that we're able to parse the type, even though we can't format it.Version
Published prerelease version:
v1.2.0-next.5
Changelog
🎉 This release contains work from new contributors! 🎉
Thanks for all your work!
❤️ Alexander Tømmerås (@flugg)
❤️ null@mvanniekerkSQ
❤️ null@swnf
❤️ Thomas (@thomaswr)
❤️ Arthur Fiorette (@arthurfiorette)
❤️ Sean Keenan (@sean9keenan)
🚀 Enhancement
🐛 Bug Fix
🔩 Dependency Updates
Authors: 9