Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with datatables 2.0 #681

Open
aureltime opened this issue Apr 1, 2024 · 8 comments
Open

Compatibility with datatables 2.0 #681

aureltime opened this issue Apr 1, 2024 · 8 comments

Comments

@aureltime
Copy link

Hello Daniel,

do you plan to make yadcf compatible with datatables 2.0 ?

@VictorioBerra
Copy link

See #680

CC @vedmack

@aureltime
Copy link
Author

thanks for the link, i close this one to avoid duplicate

@vedmack vedmack reopened this May 19, 2024
@vedmack
Copy link
Owner

vedmack commented May 19, 2024

@aureltime Yes I am, see this test page for example https://jsfiddle.net/vedmack/8bur71tk/
The current yadcf version that supports DT 2 is yadcf 2.0.1.beta.4

Feel free to provide test pages so I can apply the required modification faster

@vedmack
Copy link
Owner

vedmack commented May 22, 2024

new showcase page https://yadcf.web.app

@berndy2001
Copy link

berndy2001 commented Jun 4, 2024

Hello @vedmack

thank you for the update.

In the showcase DT 2.0.0 is used;
with a newer version (since 2.0.4) an error occurs, see fiddle. I don't know how important the version check is, but I wanted to report it anyway.

https://jsfiddle.net/msuo0e14/

"jQuery.Deferred exception: Cannot read properties of undefined (reading 'split')", "TypeError: Cannot read properties of undefined (reading 'split')
    at yadcfVersionCheck (https://raw.githack.com/vedmack/yadcf/master/2.0/jquery.dataTables.yadcf-2.0.js:832:49)

@vedmack
Copy link
Owner

vedmack commented Jun 4, 2024

@berndy2001 thx for the report, fixed in 2.0.1.beta.7, you can see here: https://jsfiddle.net/vedmack/gLjrf5ax/. I will update the showcase later on

@berndy2001
Copy link

berndy2001 commented Sep 18, 2024

Hello @vedmack

When I use the language.url option from datatables, I get an error from yadcf.

"jQuery.Deferred exception: Cannot read properties of undefined (reading 'map')", "TypeError: Cannot read properties of undefined (reading 'map')
    at appendFilters (https://raw.githack.com/vedmack/yadcf/refs/heads/master/2.0/jquery.dataTables.yadcf-2.0.js:3282:33)
    at initAndBindTable (https://raw.githack.com/vedmack/yadcf/refs/heads/master/2.0/jquery.dataTables.yadcf-2.0.js:5014:11)
    at Object.init (https://raw.githack.com/vedmack/yadcf/refs/heads/master/2.0/jquery.dataTables.yadcf-2.0.js:5224:11)
    at HTMLDocument.<anonymous> (https://fiddle.jshell.net/_display/?editor_console=true:443:9)
    at e (https://code.jquery.com/jquery-3.6.4.min.js:2:30158)
    at t (https://code.jquery.com/jquery-3.6.4.min.js:2:30460)", undefined

With datatables 1.13.5 and yadcf 0.9.4b47 this problem did not occur.

fiddle: https://jsfiddle.net/zc10mgsa/2/

@berndy2001
Copy link

berndy2001 commented Sep 19, 2024

Hello @vedmack

I found something else strange with DT2.0. If umlauts are used in combination with render, they are lost.

image

example: https://live.datatables.net/rojohici/2/edit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants