Container Identifiers #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimitribouniol
requested review from
0xTim,
gwynne and
kylebrowning
as code owners
0xTim
requested changes
May 4, 2024
| /// You must configure at lease one client in order to send notifications to devices. If you plan on supporting both development builds (ie. run from Xcode) and released builds (ie. TestFlight/App Store), you must configure at least two configurations: | ||
| /// | ||
| /// ```swift | ||
| /// let apnsKey = ... // The .p8 file as a string. |
There was a problem hiding this comment.
Let's add a note here to suggest passing it in as an environment variable and not hardcoding it in the source code
There was a problem hiding this comment.
Good callout, I’ll add a section for security considerations.
dimitribouniol
force-pushed
the
dimitri/identifiers
branch
from
b9416fb to
e7db3f9
Compare
dimitribouniol
force-pushed
the
dimitri/identifiers
branch
from
e7db3f9 to
3b4f6e3
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #58 +/- ##
===========================================
- Coverage 89.39% 64.44% -24.95%
===========================================
Files 4 4
Lines 66 90 +24
===========================================
- Hits 59 58 -1
- Misses 7 32 +25
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are now available in 4.2.0
To help users who need to configure a production and development container, added two new containerIDs:
productionanddevelopment. Also added documentation and clarified how thedefaultID is used, which isn't always the default depending on howuseis called.Note: Since this is new, I went with
developmentinstead ofsandboxhere because all of Apple's documentation refers to it as the development environment. We should probably add.developmentand deprecate.sandboxin APNSwift as well.