Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily skip tests that expect Function.blah in stack taces #204

Merged

Conversation

isheludko
Copy link

@isheludko isheludko commented Nov 19, 2024

These tests will be re-enabled once a V8 CL https://crrev.com/c/5907815 lands. The CL changes the way such entries are displayed in stack traces to Constructor.blah or Class.blah.

…ces.

These tests will be re-enabled once a V8 CL https://crrev.com/c/5907815 lands. The CL changes the way such entries are displayed in stack traces to Constructor.blah.
@victorgomes victorgomes merged commit a85d658 into v8:node-ci-2024-11-18 Nov 19, 2024
15 of 17 checks passed
victorgomes pushed a commit that referenced this pull request Dec 18, 2024
…ces. (#204)

These tests will be re-enabled once a V8 CL https://crrev.com/c/5907815 lands. The CL changes the way such entries are displayed in stack traces to Constructor.blah.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants