-
-
Notifications
You must be signed in to change notification settings - Fork 758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ICU-22922 Merge maint/maint-76 to main #3270
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you!
So... this was supposed to be a routine merge of the straggler maint/maint-76 CLDR-to-ICU integration commit from @DraganBesevic 's #3260 to main. However, we have two types of check failures here:
Since this is not a regression from this PR, I propose that we ignore it for this PR.
This looks like an MSVC config bug, unrelated to this PR. I propose that we ignore this, too, for now. @rp9-next @richgillam ok to ignore these and let Shane merge? |
Markus—
@rp9-next <https://github.com/rp9-next> @richgillam <https://github.com/richgillam> ok to ignore these and let Shane merge?
Fine with me.
—Rich
… On Nov 18, 2024, at 8:48 AM, Markus Scherer ***@***.***> wrote:
So... this was supposed to be a routine merge of the straggler maint/maint-76 CLDR-to-ICU integration commit from @DraganBesevic <https://github.com/DraganBesevic> 's #3260 <#3260> to main.
However, we have two types of check failures here:
There is a C++ exhaustive intltest failure from utility/LocaleTest/TestDataDrivenLikelySubtags <https://github.com/unicode-org/icu/actions/runs/11826108766/job/32951358852?pr=3270>. This is the same test failure that we have been seeing on main already <https://github.com/unicode-org/icu/actions/runs/11867025958>, so it's not a regression from this commit. I was hoping that this failure would get fixed with integrating the late CLDR 46 likely subtags change, but no :-/
Since this is not a regression from this PR, I propose that we ignore it for this PR.
We do need to debug & fix it on main, but not in a merge-from-maint PR.
Three of the nine MSVC checks fail with this:
"D:\a\icu\icu\icu4c\source\allinone\allinone.sln" (default target) (1) ->
"D:\a\icu\icu\icu4c\source\data\makedata_uwp.vcxproj" (default target) (56) ->
C:\Program Files\Microsoft Visual Studio\2022\Enterprise\MSBuild\Microsoft\VisualStudio\v17.0\AppxPackage\Microsoft.AppXPackage.Targets(225,25): error MSB4184: The expression "[MSBuild]::VersionGreaterThanOrEquals('', 9.0)" cannot be evaluated. Version string was not in a correct format. [D:\a\icu\icu\icu4c\source\data\makedata_uwp.vcxproj]
This looks like an MSVC config bug, unrelated to this PR. I propose that we ignore this, too, for now.
I will restart these checks to see if they were flakes.
@rp9-next <https://github.com/rp9-next> @richgillam <https://github.com/richgillam> ok to ignore these and let Shane merge?
—
Reply to this email directly, view it on GitHub <#3270 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AO65KJSTQTZWQI7S5ULYIWT2BIK5HAVCNFSM6AAAAABR4HODS6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOBTGU3TOMBXHE>.
You are receiving this because you were mentioned.
|
Thanks, Rick. |
https://unicode-org.atlassian.net/browse/ICU-22922
Follow-up to #3258 and #3260