Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICU-22606 Create an (almost) full release from CI #3222

Merged
merged 5 commits into from
Sep 30, 2024

Conversation

mihnita
Copy link
Contributor

@mihnita mihnita commented Sep 30, 2024

Automates most of the tasks required for release.

There is no need to build on Windows / Ubuntu / Fedora, there (almost) no need to upload files by hand to the GitHub Release, there is no need for PGP signing, keys, etc.

Not final, close enough.

Checklist

  • Required: Issue filed: https://unicode-org.atlassian.net/browse/ICU-22606
  • Required: The PR title must be prefixed with a JIRA Issue number. Example: "ICU-1234 Fix xyz"
  • Required: The PR description must include the link to the Jira Issue, for example by completing the URL in the first checklist item
  • Required: Each commit message must be prefixed with a JIRA Issue number. Example: "ICU-1234 Fix xyz"
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable

ALLOW_MANY_COMMITS=true

The Ubuntu and Fedora files are very similar.
But I am not sure (yet) what is the best way to share.

The files uploaded to the GitHub Release use the exact same names as before.
The .jar files are binary identical to the ones that go to Maven (checked).

The Fedora Docker image should be built and uploaded from a dev machine.
There is a workflow (from GitHub) doing that, but has a warning that:
> This workflow uses actions that are not certified by GitHub.
> They are provided by a third-party and are governed by
> separate terms of service, privacy policy, and support documentation.
@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • docs/processes/release/tasks/publish/release.md is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

markusicu
markusicu previously approved these changes Sep 30, 2024
Copy link
Member

@markusicu markusicu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rslgtm -- I might not be the best person to review this.
@echeran @rp9-next @richgillam @srl295 @yumaoka FYI

.github/README.md Outdated Show resolved Hide resolved
.github/README.md Outdated Show resolved Hide resolved
.github/workflows/icu4c.yml Show resolved Hide resolved
@mihnita
Copy link
Contributor Author

mihnita commented Sep 30, 2024

I've improved the doc a bit. I will squash at the end if you want.

Copy link
Contributor

@echeran echeran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mihnita mihnita merged commit 73626da into unicode-org:main Sep 30, 2024
102 checks passed
@mihnita
Copy link
Contributor Author

mihnita commented Sep 30, 2024

Thank you all!

I am happy to improve the doc / anything else.
But at least we now have in place everthing we need for the release.

@mihnita mihnita deleted the mihai_ci_release branch October 1, 2024 04:06
@mohd-akram
Copy link
Contributor

Putting a README file in the .github directory seems to cause it to be displayed on the project page (instead of the README file in the root directory).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants