Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ICU-22100 Improve Japanese phrase breaking performance #2287

Merged
merged 1 commit into from
Jan 31, 2023
Merged

ICU-22100 Improve Japanese phrase breaking performance #2287

merged 1 commit into from
Jan 31, 2023

Conversation

allensu05
Copy link
Contributor

@allensu05 allensu05 commented Jan 18, 2023 •
edited
Loading

  1. Use UnicodeString directly instead of type casing between char16_t* and UnicodeString
  2. Because Hashtable.geti(key) returns 0 when key doesn't exist, it doesn't need to check whether the key exists.
Checklist
  • Required: Issue filed: https://unicode-org.atlassian.net/browse/ICU-22100
  • Required: The PR title must be prefixed with a JIRA Issue number.
  • Required: The PR description must include the link to the Jira Issue, for example by completing the URL in the first checklist item
  • Required: Each commit message must be prefixed with a JIRA Issue number.
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable

allensu05 added a commit to allensu05/icu that referenced this pull request Jan 18, 2023
@allensu05
ICU-22100 Improve Japanese phrase breaking performance
d082277 
See unicode-org#2287
@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • icu4c/source/common/mlbe.cpp is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

allensu05 added a commit to allensu05/icu that referenced this pull request Jan 18, 2023
@allensu05
ICU-22100 Improve Japanese phrase breaking performance
b88fdbf 
See unicode-org#2287
@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

FrankYFTang
FrankYFTang approved these changes Jan 18, 2023
View reviewed changes
icu4c/source/common/mlbe.cpp Outdated Show resolved Hide resolved
FrankYFTang
FrankYFTang requested changes Jan 18, 2023
View reviewed changes
Copy link
Contributor

@FrankYFTang FrankYFTang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add that comment line

@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • icu4c/source/common/mlbe.cpp is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

allensu05 added a commit to allensu05/icu that referenced this pull request Jan 19, 2023
@allensu05
ICU-22100 Improve Japanese phrase breaking performance
8d124e5 
See unicode-org#2287
@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

@markusicu markusicu self-requested a review January 19, 2023 17:50
@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • icu4c/source/common/mlbe.cpp is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

allensu05 added a commit to allensu05/icu that referenced this pull request Jan 20, 2023
@allensu05
ICU-22100 Improve Japanese phrase breaking performance
aab64c8 
See unicode-org#2287
@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

@FrankYFTang
Copy link
Contributor

I fixed and landed the MacOS Latest Build + WarningAsError build breakage in
#2291
Please rebase to see the problem is fixed or not.

@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

@FrankYFTang FrankYFTang merged commit 0b3b83a into unicode-org:main Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FrankYFTang FrankYFTang FrankYFTang approved these changes

@markusicu markusicu Awaiting requested review from markusicu

Assignees

@FrankYFTang FrankYFTang

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@allensu05 @FrankYFTang