CLDR-18096 BRS 46.1 cherry-pick 46.1 changes from main to maint/maint-46, part 1 #4232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 48afc24)
(cherry picked from commit af54e7e)
…ode-org#4179) (cherry picked from commit 94942a8)
Kawi, also known as Old Javanese, is undergoing a bit of a revival. It has been written in Javanese, Balinese, and the original Kawi writing system. In modern usage the revival seems to favor the Balinese script. This was recommended by the Jira Ticket [CLDR-17160](https://unicode-org.atlassian.net/browse/CLDR-17160) and will match SIL langtags entry. ``` { "full": "kaw-Bali-MY", "iana": [ "Kawi" ], "iso639_3": "kaw", "name": "Kawi", "region": "MY", "regionname": "Malaysia", "script": "Bali", "sldr": false, "tag": "kaw", "tags": [ "kaw-Bali", "kaw-MY" ], "windows": "kaw-Bali" }, ``` (cherry picked from commit c5482d3)
…eFormats in yue_Hant (unicode-org#4193) (cherry picked from commit 4b52ae7)
(cherry picked from commit 21d9db1)
(cherry picked from commit 163a3df)
(cherry picked from commit 76f4096)
(cherry picked from commit 4a8e7c5)
(cherry picked from commit b26d82b)
…de-org#4199) (cherry picked from commit e8bcb7f)
(cherry picked from commit 9c044e1)
…de-org#4227) (cherry picked from commit 89b3e05)
… headers (cherry picked from commit a893bfb)
…, reorder keywords (cherry picked from commit bf9f761)
macchiati
approved these changes
Dec 8, 2024
|
Having to install Codespace to review. I used the following instructions:
To review a GitHub pull request in a Codespace, open the pull request
within your Codespace, then use the dedicated "GitHub Pull Request" view to
navigate through the changes, add comments directly on lines of code, and
provide feedback by approving or requesting changes, all within the
integrated development environment of your Codespace.
Key steps:
- *Open the Pull Request in Codespace:*
Navigate to the pull request on GitHub and open it in a Codespace.
- *Access the Pull Request View:*
Once in your Codespace, locate the "GitHub Pull Request" view within the
sidebar (usually accessible through the Activity Bar).
- *Review File Changes:*
Click on individual files in the sidebar to see the specific changes
made within them.
- *Add Comments:*
To leave feedback, click the "+" icon next to the line number where you
want to add a comment.
- *Submit Review:*
Once you've added your comments, use the options within the "GitHub Pull
Request" view to approve the changes, request modifications, or submit your
review with comments only.
…On Sun, Dec 8, 2024 at 10:42 AM Peter Edberg ***@***.***> wrote:
@pedberg-icu <https://github.com/pedberg-icu> requested your review on:
#4232 <#4232> CLDR-18096
<https://unicode-org.atlassian.net/browse/CLDR-18096> BRS 46.1
cherry-pick 46.1 changes from maint to maint/maint-46, part 1.
—
Reply to this email directly, view it on GitHub
<#4232 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACJLEMBDLKZPZVWKESSOXVL2ESHHRAVCNFSM6AAAAABTHPBMEWVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJVGU3TIMBRHEYTQNQ>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
|
The Formatter + Style checker failure seems to be a CI config issue: Not going to worry about it, does not block a merge. |
pedberg-icu
deleted the
CLDR-18096-BRS46-1-cherry-pick-main-to-maint-part1
branch
pedberg-icu
changed the title
Transient. Reran and it passed. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLDR-18096
This PR cherry-picks to the maint/maint-46 branch all of the 46.1 changes on the main branch through commit bf9f761 on Friday afternoon Dec 6. Those commits on main that are cherry-picked with this PR are:
de-ASCIItransform references undefinedAny-ASCIItransformkawlanguage andKawiscriptNote: This should be merged with "Rebase and merge" (temporarily enable in Settings), not the usual "Squash and merge"
ALLOW_MANY_COMMITS=true
DISABLE_JIRA_ISSUE_MATCH=true