Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDR-17843 Restore uz_Cyrl to basic coverage by fixing numerals #3938

Conversation

conradarcturus
Copy link
Contributor

This adds values for the symbols and number formats for numberSystem="arab" -- copying over the values from numberSystem="arabext". The problem was that arab was added as a number system for uz.xml (== uz_Latn.xml) so uz_Cyrl.xml needed declarations.

Ran java -jar tools/cldr-code/target/cldr-code.jar ShowLocaleCoverage to regenerate coverage level text.

CLDR-17843

  • This PR completes the ticket.

ALLOW_MANY_COMMITS=true

This adds values for the symbols and number formats for `numberSystem="arab"` -- copying over the values from `numberSystem="arabext"`. The problem was that arab was added as a number system for uz.xml (== uz_Latn.xml) so uz_Cyrl.xml needed declarations.

Ran `java -jar tools/cldr-code/target/cldr-code.jar ShowLocaleCoverage` to regenerate coverage level text.
@srl295 srl295 requested a review from macchiati August 6, 2024 19:09
@@ -155,6 +155,7 @@ tt ; moderate ; Tatar
uk ; modern ; Ukrainian
ur ; modern ; Urdu
uz ; modern ; Uzbek
uz_Cyrl ; basic ; Uzbek (Cyrillic)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

common/properties/coverageLevels.txt is automatically rebuilt, so shouldn't have manual changes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Er, it's in a manual commit but I ran the script to make the change. I'm used to re-generating artefacts in the commit that changes them rather than waiting for scheduled commit -- just to keep everything up to date. It's also a good validation check to make sure the change did the right thing.

@conradarcturus conradarcturus merged commit 30814c7 into unicode-org:main Aug 6, 2024
10 checks passed
@conradarcturus conradarcturus deleted the CLDR-17843-Fix-Uzbek-coverage branch August 6, 2024 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants