New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLDR-17560 don't show whole-locale warnings on row #3817

Merged

srl295 merged 1 commit into unicode-org:main from srl295:cldr-17560/dont-color-whole-locale-errs

Jun 20, 2024

Member

srl295 commented Jun 20, 2024

whole-locale warnings/errs should not affect the kind (color) of a candidate item.

This PR completes the ticket.

To Test:

go to the 'csw' locale, such as https://cldr-smoke.unicode.org/cldr-apps/v#/csw/Graphics/
you should NOT see every locale with a yellowish-tint background.

Wrong:

Correct:

ALLOW_MANY_COMMITS=true


          CLDR-17560 don't show whole-locale warnings on row

e4c8316

- whole-locale warnings/errs should not affect the kind (color) of a candidate item.

srl295 requested review from macchiati, AEApple and btangmu

June 20, 2024 19:24

srl295 self-assigned this

macchiati approved these changes

View reviewed changes

srl295 merged commit 03e7b4d into unicode-org:main

12 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet