CLDR-17719 update v46 charts #3800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
re: Airbnb they are focusing on specific data types. Will it lead to any confusion if we include them? |
srl295
previously approved these changes
Jun 12, 2024
|
re: Airbnb they are focusing on specific data types. Will it lead to any
confusion if we include them?
I'll modify to leave them out until we confirm, since it isn't really full
'modern'.
…On Tue, Jun 11, 2024 at 7:00 PM Annemarie Apple ***@***.***> wrote:
re: Airbnb they are focusing on specific data types. Will it lead to any
confusion if we include them?
—
Reply to this email directly, view it on GitHub
<#3800 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACJLEMEF642ORUEU4KIY3CTZG6TT7AVCNFSM6AAAAABJFMEN4CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNRRHE2TCNRUGE>
.
You are receiving this because you were assigned.Message ID:
***@***.***>
|
srl295
previously approved these changes
Jun 12, 2024
srl295
reviewed
Jun 12, 2024
| .addColumn( | ||
| "Code", | ||
| "class='source'", | ||
| "<a href=\"http://www.unicode.org/cldr/data/common/main/{0}.xml\">{0}</a>", |
There was a problem hiding this comment.
Suggested change
| "<a href=\"http://www.unicode.org/cldr/data/common/main/{0}.xml\">{0}</a>", | |
| "<a href=\"https://www.unicode.org/cldr/data/common/main/{0}.xml\">{0}</a>", |
- http should be https
- should use a CLDRURLS constant anyway
- this URL looks wrong and doesn't seem to work. were you wanting something such as https://github.com/unicode-org/cldr/blob/main/common/main/fr.xml etc?
|
Ah, yes, this probably dates way back. Will fix.
…On Wed, Jun 12, 2024 at 12:10 PM Steven R. Loomis ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In tools/cldr-code/src/main/java/org/unicode/cldr/tool/ShowLanguages.java
<#3800 (comment)>:
> + SUPPLEMENTAL_INDEX_ANCHORS));
+ PrintWriter coverageGoalsTsv =
+ FileUtilities.openUTF8Writer(
+ CLDRPaths.CHART_DIRECTORY + "tsv/", "coverage_goals.tsv"); ) {
+
+ TablePrinter tablePrinter =
+ new TablePrinter()
+ // tablePrinter.setSortPriorities(0,4)
+ .addColumn(
+ "Language", "class='source'", null, "class='source'", false)
+ .setSortPriority(0)
+ .setBreakSpans(false)
+ .addColumn(
+ "Code",
+ "class='source'",
+ "<a href=\"http://www.unicode.org/cldr/data/common/main/{0}.xml\">{0}</a>",
⬇️ Suggested change
- "<a href=\"http://www.unicode.org/cldr/data/common/main/{0}.xml\">{0}</a>",
+ "<a href=\"https://www.unicode.org/cldr/data/common/main/{0}.xml\">{0}</a>",
1. http should be https
2. should use a CLDRURLS constant anyway
3. this URL looks wrong and doesn't seem to work. were you wanting
something such as
https://github.com/unicode-org/cldr/blob/main/common/main/fr.xml etc?
—
Reply to this email directly, view it on GitHub
<#3800 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACJLEMBQY326ZVJTJ4L2RATZHCMLDAVCNFSM6AAAAABJFMEN4CVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCMJTHE2TEMJQGU>
.
You are receiving this because you were assigned.Message ID:
***@***.***>
|
|
After making the fix you recommended, I searched for https://github.com/unicode-org/cldr and got the following hits in our source: ConsoleCheckCLDR.java CLDRModify.java GenerateTransformCharts.java ShowLanguages.java ShowLocaleCoverage.java TestCheckCLDR.java NOTE
What do you think? |
|
FYI CLDR_REPO_ROOT and CLDR_REPO_BASE have the same definition currently |
this is probably the best way to do it. Maybe include a trailing slash ( |
|
Ok, will do
…On Wed, Jun 12, 2024 at 2:42 PM Steven R. Loomis ***@***.***> wrote:
@macchiati <https://github.com/macchiati>
CLDRURLS.CLDR_REPO_MAIN = CLDR_REPO_BASE + "/blob/main"
this is probably the best way to do it. Maybe include a trailing slash (
/blob/main/) so you can do CLDRURLS.CLDR_REPO_MAIN + "common/main/fr.xml"
—
Reply to this email directly, view it on GitHub
<#3800 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACJLEMFBEXKZBJMBHOX3T53ZHC6E5AVCNFSM6AAAAABJFMEN4CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNRTHE2TCNBTGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
This works now, after the change in constants that Steven noted. So it's ready to go. |
|
Could someone approve this? |
srl295
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLDR-17719
I found that the coverage_goals.html chart was omitting Meta. I put in a fix so that it would be driven by the Organization.getTCOrgs().
I also generate a .tsv that reformats the Locales.txt data. The reformatted data sorts TC locales first, then others. It does not overwrite Locales.txt, but rather creates the .tsv with the staging charts.
The format looks like:
ALLOW_MANY_COMMITS=true